Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to async/await syntax #8

Merged
merged 3 commits into from Oct 31, 2018
Merged

Move to async/await syntax #8

merged 3 commits into from Oct 31, 2018

Conversation

kxepal
Copy link
Collaborator

@kxepal kxepal commented Oct 29, 2018

This drops Python 3.4 support which shouldn't be a tragedy. Also, we
forbid to iterate over Traversal objects, you await instead.

In other words, before:

iter(root['a']['b'])

Now:

await root['a']['b']

@kxepal kxepal requested a review from zzzsochi October 29, 2018 19:11
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 82.315% when pulling ce51feb on async-await into 80822f6 on master.

@coveralls
Copy link

coveralls commented Oct 29, 2018

Coverage Status

Coverage decreased (-0.1%) to 82.315% when pulling a1c3851 on async-await into 80822f6 on master.

kxepal and others added 3 commits October 29, 2018 22:20
This drops Python 3.4 support which shouldn't be a tragedy. Also, we
forbid to iterate over Traversal objects, you await instead.

In other words, before:
```
iter(root['a']['b'])
```

Now:
```
await root['a']['b']
```
We still have deprecation warning about `router` argument, but that's
would not so easy to fix.
@zzzsochi zzzsochi merged commit cbd1f7f into master Oct 31, 2018
@zzzsochi zzzsochi deleted the async-await branch October 31, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants