Skip to content

changes names of some vars/secrets #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rdietrick
Copy link
Collaborator

@gfarb had opened a PR with these changes a long time ago. I couldn't rebase his cause it's from his private repo, so this replaces it.

@gfarb had opened a PR with these changes a long time ago.
@Copilot Copilot AI review requested due to automatic review settings March 20, 2025 03:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces an earlier submission by updating variable and secret names to distinguish production credentials from development ones. Key changes include:

  • Renaming secrets in GitHub Actions workflows to use production identifiers.
  • Updating documentation to reflect the renamed variables.
  • Modifying the issue branch creation workflow to align with these naming changes.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/push-to-main-handler.yml Updated secret names and deployment commands for production use.
docs/Getting Started.md Adjusted documentation to reference production secret names.
.github/workflows/issue-branch-creation-handler.yml Revised secret names for production in the branch creation workflow.
Files not reviewed (1)
  • scripts/sandbox_auth: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@@ -122,7 +143,7 @@ jobs:
if: steps.requires-deploy.outputs.changed == '1'
run: |
echo "${SALESFORCE_TEMPLATE_JWT_SECRET_KEY}" > template-server.key
sudo npx sf org login jwt --client-id ${{ secrets.SALESFORCE_TEMPLATE_CONSUMER_KEY }} --jwt-key-file template-server.key --username ${{ secrets.SALESFORCE_TEMPLATE_USERNAME}} --alias Template --instance-url https://test.salesforce.com
sudo npx sf org login jwt --client-id ${{ secrets.SALESFORCE_TEMPLATE_CLIENT_ID }} --jwt-key-file server.key --username ${{ secrets.SALESFORCE_TEMPLATE_USERNAME}} --alias Template --instance-url https://test.salesforce.com
Copy link
Preview

Copilot AI Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key file referenced for JWT authentication does not match the file created in a previous step ('template-server.key'); update the command to use 'template-server.key'.

Suggested change
sudo npx sf org login jwt --client-id ${{ secrets.SALESFORCE_TEMPLATE_CLIENT_ID }} --jwt-key-file server.key --username ${{ secrets.SALESFORCE_TEMPLATE_USERNAME}} --alias Template --instance-url https://test.salesforce.com
sudo npx sf org login jwt --client-id ${{ secrets.SALESFORCE_TEMPLATE_CLIENT_ID }} --jwt-key-file template-server.key --username ${{ secrets.SALESFORCE_TEMPLATE_USERNAME}} --alias Template --instance-url https://test.salesforce.com

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant