-
Notifications
You must be signed in to change notification settings - Fork 257
Add a sample of sparse packaged Winforms using WCR #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a sample of sparse packaged Winforms using WCR #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Added a few small comments.
} | ||
base.Dispose(disposing); | ||
|
||
// Find and end WCRforWinformsSparse.exe process as best effort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this "Find an end" code an effort to fix the process hang issue you mentioned? I wouldn't expect this to be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there were instances when I could click 'exit' on the main form even though everything else was unresponsive and hanging. Hence, I added code in the dispose method to ensure the process ends if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could maybe understand killing/exiting the current process, but finding and killing other processes seems weird.
I wondered if this code may have been added due to the extra run code which you've now removed, but the symptom you described sounds different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this a bit more, I am inclined to remove this for now. I will revisit later if the sample application persistently continues to hang and will make a note to verify this when samples will be updated to the stable release. Thanks!
Description
This pull request includes sample code demonstrating how to invoke WCR APIs within a Windows Forms application (sparse packaged). The application performs text recognition and summarization of text on an image after displaying package information.
Target Release
The example currently targets the 1.7-experimental3 which contains the WCR API. However, this will be updated in the future to target the stable release when it becomes available.
Checklist
Note that /azp run currently isn't working for this repo.