Update NPM dependencies #1703
Merged
Update NPM dependencies #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jww3
approved these changes
Apr 23, 2024
cory-miller
commented
Apr 23, 2024
.licenses/npm/@actions/core.dep.yml
Outdated
There was a problem hiding this comment.
The license updates are from npm run licensed-generate. You can use the file filter to hide the YML files.
cory-miller
commented
Apr 23, 2024
| @@ -8,7 +8,7 @@ import * as path from 'path' | |||
| import * as regexpHelper from './regexp-helper' | |||
| import * as stateHelper from './state-helper' | |||
| import * as urlHelper from './url-helper' | |||
| import {default as uuid} from 'uuid/v4' | |||
| import {v4 as uuid} from 'uuid' | |||
There was a problem hiding this comment.
There should be no functional change. This is adapting to the library update.
cory-miller
commented
Apr 23, 2024
| @@ -6,7 +6,7 @@ import * as io from '@actions/io' | |||
| import * as path from 'path' | |||
| import * as retryHelper from './retry-helper' | |||
| import * as toolCache from '@actions/tool-cache' | |||
| import {default as uuid} from 'uuid/v4' | |||
| import {v4 as uuid} from 'uuid' | |||
There was a problem hiding this comment.
There should be no functional change. This is adapting to the library update.
cory-miller
commented
Apr 23, 2024
| @@ -20,7 +20,7 @@ function updateUsage( | |||
| } | |||
|
|
|||
| // Load the action.yml | |||
| const actionYaml = yaml.safeLoad(fs.readFileSync(actionYamlPath).toString()) | |||
| const actionYaml = yaml.load(fs.readFileSync(actionYamlPath).toString()) | |||
There was a problem hiding this comment.
There should be no functional change. This is adapting to the library update.
cory-miller
commented
Apr 23, 2024
| @@ -1,5 +1,6 @@ | |||
| module.exports = { | |||
| clearMocks: true, | |||
| fakeTimers: {}, | |||
There was a problem hiding this comment.
Jest has this called out in their 28.x upgrade docs.
1 task
This was referenced Dec 31, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several dependabot alerts that are unable to pass CI because of build errors.
I've gone through and updated them. For the most part the issues were related to needing to be updated together (so I may need to revisit the major version grouping in the Dependabot config I just added). However, some version updates required updating our module usage.
The TS updates also cause some formatting changes when running
npm run format.