Add GITHUB_REF_TYPE and GITHUB_REF_NAME support to github context #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenKoren
changed the title
|
Why don't you add cf. https://docs.github.com/en/actions/learn-github-actions/environment-variables |
|
Done. :) |
|
@peaceiris can we merge this ? |
peaceiris
reviewed
Mar 16, 2022
| @@ -40,6 +43,9 @@ export class Context { | |||
| this.eventName = process.env.GITHUB_EVENT_NAME as string | |||
| this.sha = process.env.GITHUB_SHA as string | |||
| this.ref = process.env.GITHUB_REF as string | |||
| this.refName = process.env.GITHUB_REF_NAME as string | |||
| this.refType = process.env.GITHUB_REF_TYPE as string | |||
| this.refProtected = (process.env.GITHUB_REF_PROTECTED as string) === 'true' | |||
There was a problem hiding this comment.
The GITHUB_REF_PROTECTED is expected to have true, so I think the current implementation is sufficient. We need the opinion of the maintainers about this.
cf. https://docs.github.com/en/actions/learn-github-actions/environment-variables
|
LGTM |
|
How to get the approval from actions/actions-runtime? Seems it is the only thing left before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope it is all changes required to pass ref_type info from env to github context.
It's first time I touch actions toolkit and I'm not sure if I hadn't miss something.