Skip to content

Fix PR Labeler #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix PR Labeler #569

wants to merge 3 commits into from

Conversation

ok-coder1
Copy link
Collaborator

Fixed the python label being added to almost every PR for some reason.

* fixed the `python` label being added to almost every PR for some reason
@ok-coder1 ok-coder1 self-assigned this Jun 3, 2025
@github-actions github-actions bot added the python Pull requests that update Python code label Jun 3, 2025
Copy link

github-actions bot commented Jun 3, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jun 3, 2025
@ok-coder1 ok-coder1 removed the python Pull requests that update Python code label Jun 3, 2025
@github-actions github-actions bot added the python Pull requests that update Python code label Jun 3, 2025
@ok-coder1 ok-coder1 removed the python Pull requests that update Python code label Jun 3, 2025
Copy link
Owner

@anmol098 anmol098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Code Review by Dume.ai, on behalf of @anmol098

Hello, this pull request has been reviewed by Dume.ai, the AI executive assistant to @anmol098.

Dume has carefully analyzed the changes and provided targeted inline comments to help improve clarity, quality, and maintainability of the code.

If you have any questions or need clarification, please refer to the inline feedback or feel free to tag @anmol098.

Review performed on 2025-06-09T04:49:56.972Z

Powered by Dume.ai – Your AI executive assistant for engineering workflows.

@@ -1,9 +1,10 @@
name: "Pull Request Labeler"
name: Pull Request Labeler
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 AI Review: - Code Quality: The change from "Pull Request Labeler" to Pull Request Labeler in the name field improves readability by removing unnecessary quotes.

  • Code Quality: Adding name: Label PRs to the labeler job provides a clearer description of the job's purpose in the workflow run. This enhances readability and maintainability.
  • Potential Issue: The workflow trigger is pull_request_target. Ensure this is the correct trigger for the intended use case. pull_request_target allows the workflow to access the contents of the base branch, but also introduces security considerations as it runs in the context of the base branch. If the workflow doesn't need to modify the base branch, consider using pull_request instead.

@@ -14,10 +14,11 @@ documentation:
github_actions:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 AI Review: - Bug and Issue Identification: The original python label configuration excluded sources/translation.json. The new configuration only includes sources/**.py, effectively dropping the exclusion. This might be unintentional, as changes to sources/translation.json might still require a translation label.

  • Improvement Suggestion: The python section should be reviewed to ensure that it correctly identifies Python-related changes. Consider keeping the original configuration and adding .py to the glob, or explicitly adding a rule for translation.json if it should be labeled differently.
  • Code Quality: The addition of .github/labeler.yml to the github_actions section is good for ensuring that changes to the labeler configuration itself are properly labeled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants