-
Notifications
You must be signed in to change notification settings - Fork 179
FRC-0104: Common Node API #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRC-0104: Common Node API #1158
Conversation
Co-authored-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
Co-authored-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
Co-authored-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
| GasEstimateFeeCap | Transactions | Returns the estimated fee cap for the given parameters. | | ||
| GasEstimateGasLimit | Transactions | Returns the estimated gas limit for the given parameters. | | ||
| GasEstimateGasPremium | Transactions | Returns the estimated gas premium for the given parameters. | | ||
| GasEstimateMessageGas | Transactions | Returns the estimated gas for the given parameters. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GasEstimateMessageGas
is missing from common-node-api.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the repeated issue, I've added the method. Now the md-table is in sync with the json.
Perhaps this helps to check they are in sync? Could be included in the FRC maybe just to make sure into the future that it's in sync? Currently shows |
Co-authored-by: Rod Vagg <rod@vagg.org>
Thanks @rvagg, I added the script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, let's land this plane
As discussed during FDS-6 in Toronto, I'm opening this PR as a replacement for the previously closed #1027.
The OpenRPC spec is added to the resources directory.