Skip to content

FRC-0104: Common Node API #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 25, 2025

Conversation

AlexeyKrasnoperov
Copy link
Contributor

As discussed during FDS-6 in Toronto, I'm opening this PR as a replacement for the previously closed #1027.

The OpenRPC spec is added to the resources directory.

@BigLep BigLep mentioned this pull request May 27, 2025
@BigLep BigLep added this to FilOz Jun 3, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Jun 3, 2025
@BigLep BigLep moved this from 📌 Triage to 🐱 Todo in FilOz Jun 3, 2025
@BigLep BigLep moved this from 🐱 Todo to 🔎 Awaiting Review in FilOz Jun 3, 2025
@BigLep BigLep requested a review from masih June 3, 2025 04:36
| GasEstimateFeeCap | Transactions | Returns the estimated fee cap for the given parameters. |
| GasEstimateGasLimit | Transactions | Returns the estimated gas limit for the given parameters. |
| GasEstimateGasPremium | Transactions | Returns the estimated gas premium for the given parameters. |
| GasEstimateMessageGas | Transactions | Returns the estimated gas for the given parameters. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GasEstimateMessageGas is missing from common-node-api.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the repeated issue, I've added the method. Now the md-table is in sync with the json.

@rvagg
Copy link
Member

rvagg commented Jun 18, 2025

diff <(awk '/^\| Method.*\| Category.*\| Description/ {getline; while (getline && /^\|/) {if ($0 !~ /^\|---/) {gsub(/^ *\| */, "", $0); gsub(/ *\|.*/, "", $0); gsub(/^ *| *$/, "", $0); print $0}}}' FRCs/frc-0104.md | sort) <(grep -o '"name": "Filecoin\.[^"]*"' resources/frc-0104/common-node-api.json | grep -v '\.Result"' | sed 's/"name": "Filecoin\.//;s/"//' | sort)

Perhaps this helps to check they are in sync? Could be included in the FRC maybe just to make sure into the future that it's in sync? Currently shows < GasEstimateMessageGas as @lanzafame pointed out.

@AlexeyKrasnoperov
Copy link
Contributor Author

diff <(awk '/^\| Method.*\| Category.*\| Description/ {getline; while (getline && /^\|/) {if ($0 !~ /^\|---/) {gsub(/^ *\| */, "", $0); gsub(/ *\|.*/, "", $0); gsub(/^ *| *$/, "", $0); print $0}}}' FRCs/frc-0104.md | sort) <(grep -o '"name": "Filecoin\.[^"]*"' resources/frc-0104/common-node-api.json | grep -v '\.Result"' | sed 's/"name": "Filecoin\.//;s/"//' | sort)

Perhaps this helps to check they are in sync? Could be included in the FRC maybe just to make sure into the future that it's in sync? Currently shows < GasEstimateMessageGas as @lanzafame pointed out.

Thanks @rvagg, I added the script.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, let's land this plane

@github-project-automation github-project-automation bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FilOz Jun 25, 2025
@rvagg rvagg merged commit 1938a19 into filecoin-project:master Jun 25, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

5 participants