fix: assert that EC finalized tipset height is never negative in v2 APIs #13180
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an edge case where if the head epoch is below the chain finality policy (defaulting to 900) EC finalized head height would become negative. Fixes: #13167
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an edge case where the EC finalized tipset height could become negative by ensuring it is set to a minimum of zero.
- Updated the calculation of finalizedHeight using max(0, head.Height()-policy.ChainFinality)
- Prevents negative tipset height in v2 APIs
Comments suppressed due to low confidence (1)
node/impl/full/chain_v2.go:156
- Ensure that the function 'max' is defined for integer comparisons. If not, consider implementing an integer-specific max function to avoid potential type issues.
finalizedHeight := max(0, head.Height()-policy.ChainFinality)
rvagg
approved these changes
Jun 19, 2025
github-project-automation
bot
moved this from 🔎 Awaiting Review
to ✔️ Approved by reviewer
in FilOz
|
oh, v2 tests are failing with this, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an edge case where if the head epoch is below the chain finality policy (defaulting to 900) EC finalized head height would become negative.
Fixes: #13167