Rust: Simple type inference for index expressions #19657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/type-inference-index-expr-simple
branch
2 times, most recently
from
214079f to
2652887
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * [1]: https://doc.rust-lang.org/reference/expressions/array-expr.html#r-expr.array.index | ||
| */ | ||
| pragma[nomagic] | ||
| private Type inferIndexExprType(IndexExpr ie, TypePath path) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
force-pushed
the
rust/type-inference-index-expr-simple
branch
3 times, most recently
from
351a981 to
d8161df
Compare
hvitved
force-pushed
the
rust/type-inference-index-expr-simple
branch
from
d8161df to
133aca0
Compare
geoffw0
reviewed
Jun 11, 2025
| TRefTypeParameter() or | ||
| TSelfTypeParameter(Trait t) | ||
| TSelfTypeParameter(Trait t) or | ||
| TSliceTypeParameter() |
There was a problem hiding this comment.
Out of interest, how are these different? i.e. why is just one TypeParameter() type insufficient?
There was a problem hiding this comment.
We model slice types as if there was a special struct Slice<T> = ... type, and TSliceTypeParameter corresponds to the T. So e.g. [i64] translates to Slice<i64>.
geoffw0
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
I'm happy, up to you if you want to wait for a review from @paldepind as well or not.
paldepind
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simple type inference for index expressions like
x[0]. Support is simple because we do not properly model theIndextrait, but instead we only supportVec. Slice and array types are modeled correctly.DCA confirms that we are now able to resolve more calls.