Rust: expand attribute macros on AssocItem #19823
Open
+213
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
force-pushed
the
aibaars/rust-expand-assoc-items
branch
3 times, most recently
from
705f5dc to
e69d76c
Compare
redsun82
reviewed
Jun 20, 2025
| @@ -0,0 +1,3 @@ | |||
| qltest_cargo_check: true | |||
There was a problem hiding this comment.
this is the default, inherited from the toplevel options.yml, so no need to specify it
Comment on lines
81
to
89
|
|
||
| #[ctor::ctor] | ||
| fn foo_ctor() {} | ||
|
|
||
| #[cfg(any(target_os = "linux", not(target_os = "linux")))] | ||
| fn bar() {} | ||
|
|
||
| #[cfg(all(target_os = "linux", not(target_os = "linux")))] | ||
| fn baz() {} |
There was a problem hiding this comment.
I don't think this is really needed or relevant
- the
ctor::ctorcase is covered by our custom macro - the
cfgcases aren't even macros
So I'd revert this and remove the options.yml file. A test without external dependencies is also a quicker test.
| } | ||
| }; | ||
| ($($_:tt)*) => {}; | ||
| } | ||
|
|
||
| impl From<crate::trap::Label<generated::AssocItem>> for crate::trap::Label<generated::Item> { |
There was a problem hiding this comment.
please let's put in a TODO that this is temporary while we look for a solution going through the generated schema
Co-authored-by: Paolo Tranquilli <redsun82@github.com>
aibaars
force-pushed
the
aibaars/rust-expand-assoc-items
branch
from
e5ca1eb to
2acce96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.