C#: Support suppression comments in XML files #4948
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
requested changes
Jan 19, 2021
csharp/ql/src/XMLAlertSuppression.ql
Outdated
| /** | ||
| * An alert suppression comment. | ||
| */ | ||
| class SuppressionComment extends XMLComment { |
There was a problem hiding this comment.
It feels like this class and SuppressionScope should be in XML.qll, so it can be reused by other languages.
hvitved
approved these changes
Mar 1, 2021
hvitved
requested changes
Mar 1, 2021
hvitved
approved these changes
Mar 2, 2021
|
Should this change be documented in a change-note? |
It probably should, yes. |
|
This one seems to have fallen through the cracks. Should it be resurrected, or is it no longer relevant? |
|
Probably worth resurrecting at some point - I think C# is still the only language where our queries report results in XML files, but it's still possible for custom queries to report results in XML for other languages. |
|
Is this still live or can it be closed/drafted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
@kind alert-suppressionquery which handles XML comments and accepts the same format as the existing query for C# comments.