refactor: asset-grid, actions #19238
Conversation
|
I'd probably try to do the component refactoring first and move it later, otherwise you will constantly end up with conflicts for anything and everything that's also changed in the asset-grid file. |
…mponent Separated scrubber logic into asset-grid component, creating a asset-grid-without-scrubber for modularity. Names not final yet, much more left to do.
|
Not sure I follow what your saying. My technique is to break apart everything into smaller chunks, and then shift and move things until they make sense. This is not final by any stretch. i.e. the actions won't use bind mounts in the final result, rather the'll be passed in from the parent. I'm starting to settle on 'timeline' as the main replacement for 'asset-grid' which will contain all the actions/sections/behavior (but more modular) as asset-grid does today. Then there will be a timeline-viewer component, which is just the viewer, no scrubber. And then a timeline-scrubber - which includes the scrubber. The scrubber itself will likely remain as it is. The actions will be modularized, and made reusable (sharing the keyboard shortcuts and the action menu item logic). DateGroup will be renamed to photo-group, or similar. After all this is all done, I'm thinking of making the timeline more generic, and not necessarily focused on time. i.e. imagine showing all the albums as one stream, but divisions where the albums name. At that point, I may end up extracting a 'photo-stream' component away from the 'timeline' which would end up being just a specialization of photo-stream. A nd, at some point, and I'm going to extract away the data-loader parts of the timeline. So, you can supply the photos in alternative ways. i.e. imagine a totally static/standalone component, where the data comes from a json file. then timeline becomes a true component, maybe even something in @immich/ui (but probably not) oh, and i'm going to take this slow |
Improve general timeline components, breaking up the huge components into smaller chunks. Will try to group changes into smaller commits within this PR.