Fix(OpenVINO): Ensure numpy.prod passes tests and handles boolean inp… #21403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21403 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 565 565
Lines 55073 55100 +27
Branches 8571 8578 +7
=======================================
+ Hits 45532 45556 +24
- Misses 7443 7445 +2
- Partials 2098 2099 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rkazants
reviewed
Jun 19, 2025
.gitignore
Outdated
Comment on lines
21
to
23
| .ruff_cache No newline at end of file | ||
| .ruff_cache | ||
| my_clean_keras_env_py310/ |
There was a problem hiding this comment.
please revert these changes
rkazants
reviewed
Jun 19, 2025
keras/src/backend/openvino/numpy.py
Outdated
Comment on lines
1281
to
1294
| promotion_map = { | ||
| Type.bf16: Type.bf16, | ||
| Type.f16: Type.f16, | ||
| Type.f32: Type.f32, | ||
| Type.f64: Type.f64, | ||
| Type.i8: Type.i32, | ||
| Type.i16: Type.i32, | ||
| Type.i32: Type.i32, | ||
| Type.i64: Type.i64, | ||
| Type.u8: Type.u32, | ||
| Type.u16: Type.u32, | ||
| Type.u32: Type.u32, | ||
| Type.u64: Type.u64, | ||
| } |
There was a problem hiding this comment.
please use the same dictionary from core.py
rkazants
reviewed
Jun 19, 2025
keras/src/backend/openvino/numpy.py
Outdated
|
|
||
| temporary_result = ov_opset.reduce_prod(x, axis, keepdims).output(0) |
There was a problem hiding this comment.
name this var prod_result
…Mezalfa/keras into feature/openvino-numpy-prod-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements keras.numpy.prod for the OpenVINO backend.
Features:
Handles reduction along specified axes, including single integers, tuples, and None.
Implements promotion for dtype when dtype is passed as None ,converting to a suitable OpenVINO type.
If dtype is specified, the output is converted to the specified dtype.
Properly manages the keepdims argument to retain or drop the reduced dimensions in the output shape.