fix(61867): fix find-all-refs for constructors involving string literals #61869
+94
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Andarist
reviewed
Jun 15, 2025
| isLiteralNameOfPropertyDeclarationOrIndexAccess(str) || | ||
| isNameOfModuleDeclaration(node) || | ||
| isExpressionOfExternalModuleImportEqualsDeclaration(node) || | ||
| (isCallExpression(node.parent) && isBindableObjectDefinePropertyCall(node.parent) && node.parent.arguments[1] === node) || | ||
| isImportOrExportSpecifier(node.parent) | ||
| ); | ||
| ) && str.text.length === searchSymbolName.length; |
There was a problem hiding this comment.
this might fix the issue at hand but this check could be seen as (minor) perf optimization - it should be cheaper to perform this length-based check first
the true issue here, I feel, is that something that claims to be a StringLiteral... doesn't behave like one. A StringLiteralLike must have .text - it's an invariant that is broken here.
I feel like this is closer to what the proper fix should look like: Andarist@38551b1
But I'd fully expect it to need some adjustments. What I don't feel confident enough:
- should this be somehow also passed to object allocators?
- maybe the
textassignment should be handled byaddSyntheticNodesas that's a function that deals with the scanner - and maybe then a custom/extra
StringLiteralObjectwouldn't be needed? One could cast and assign.textto the createdTokenObject - obviously the proposed fix might require some extra other properties to be set - what about
singleQuote? Is it safely omittable? - it feels like string literals wouldn't necessarily be the only token kinds that might be broken right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61867
Fix regression in fix-all-refs for constructors with string literals by moving the length check after node kind checks