feat: add ember to vite create
#20069
Conversation
NullVoxPopuli
force-pushed
the
add-ember-create
branch
from
74b270e to
265dfb5
Compare
NullVoxPopuli
force-pushed
the
add-ember-create
branch
from
265dfb5 to
a0d3bfc
Compare
NullVoxPopuli
changed the title
vite create
| variants: [ | ||
| { | ||
| name: 'ember app', | ||
| display: 'Production-ready App', |
There was a problem hiding this comment.
display value ends with the "up-right" arrow to signal that it is calling an external cli
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| display: 'Production and OSS ready Library', | ||
| color: redBright, | ||
| customCommand: | ||
| 'npx ember-cli@latest addon TARGET_DIR --blueprint @ember/addon-blueprint --pnpm --typescript', |
There was a problem hiding this comment.
The non-TypeScript library variant (line 270) includes the --typescript flag in its command, which contradicts its purpose. Please remove the --typescript flag from this command to correctly represent the non-TypeScript version:
'npx ember-cli@latest addon TARGET_DIR --blueprint @ember/addon-blueprint --pnpm'
| 'npx ember-cli@latest addon TARGET_DIR --blueprint @ember/addon-blueprint --pnpm --typescript', | |
| 'npx ember-cli@latest addon TARGET_DIR --blueprint @ember/addon-blueprint --pnpm', |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
how do I tell the bot that I want to keep TS?
| display: 'Production-ready App', | ||
| color: redBright, | ||
| customCommand: | ||
| 'npx ember-cli@latest new TARGET_DIR --blueprint @ember/app-blueprint --pnpm --lang en', |
There was a problem hiding this comment.
--pnpm and --lang en are opinionated choices, does ember-cli come with an interactive mode that allows users to pick them? or maybe investigate reusing the detected package manager from create-vite cli
There was a problem hiding this comment.
it does have an interactive mode, ya , tho --lang isn't required.
r maybe investigate reusing the detected package manager from create-vite cli
oh, how do you do that? that sounds cool
| display: 'Production and OSS ready Library', | ||
| color: redBright, | ||
| customCommand: | ||
| 'npx ember-cli@latest addon TARGET_DIR --blueprint @ember/addon-blueprint --pnpm --typescript', |
There was a problem hiding this comment.
do ember libraries leverage vite during their build process? (vite library mode?) create-vite is primarily used for creating applications using vite, i don't think we have explicit library support for any other option
There was a problem hiding this comment.
yea, we use vite for testing, we boot up an in-memory app which can be used for tests, the library's docs, etc
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
| display: 'Production and OSS ready Library', | ||
| color: redBright, | ||
| customCommand: | ||
| 'npx ember-cli@latest addon TARGET_DIR --blueprint @ember/addon-blueprint --pnpm --typescript', |
There was a problem hiding this comment.
There appears to be an inconsistency in the ember-library variant configuration. The non-TypeScript variant currently includes the --typescript flag in its command:
npx ember-cli@latest addon TARGET_DIR --blueprint @ember/addon-blueprint --pnpm --typescript
This should be modified to remove the TypeScript flag for the non-TypeScript variant:
npx ember-cli@latest addon TARGET_DIR --blueprint @ember/addon-blueprint --pnpm
This will ensure proper differentiation between the TypeScript and non-TypeScript library variants.
| 'npx ember-cli@latest addon TARGET_DIR --blueprint @ember/addon-blueprint --pnpm --typescript', | |
| 'npx ember-cli@latest addon TARGET_DIR --blueprint @ember/addon-blueprint --pnpm', |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| @@ -100,7 +102,7 @@ $ deno init --npm vite my-vue-app --template vue | |||
|
|
|||
| ::: | |||
|
|
|||
| See [create-vite](https://github.com/vitejs/vite/tree/main/packages/create-vite) for more details on each supported template: `vanilla`, `vanilla-ts`, `vue`, `vue-ts`, `react`, `react-ts`, `react-swc`, `react-swc-ts`, `preact`, `preact-ts`, `lit`, `lit-ts`, `svelte`, `svelte-ts`, `solid`, `solid-ts`, `qwik`, `qwik-ts`. | |||
| See [create-vite](https://github.com/vitejs/vite/tree/main/packages/create-vite) for more details on each supported template: `vanilla`, `vanilla-ts`, `vue`, `vue-ts`, `react`, `react-ts`, `react-swc`, `react-swc-ts`, `preact`, `preact-ts`, `lit`, `lit-ts`, `svelte`, `svelte-ts`, `ember`, `ember-ts`, `solid`, `solid-ts`, `qwik`, `qwik-ts`. | |||
There was a problem hiding this comment.
The template names in the documentation need to be updated to match the actual implementation. Currently it shows ember and ember-ts, but the code defines four distinct templates: ember-app, ember-app-ts, ember-library, and ember-library-ts. Please update the documentation to list all four template options for accuracy and to avoid confusion for users.
| See [create-vite](https://github.com/vitejs/vite/tree/main/packages/create-vite) for more details on each supported template: `vanilla`, `vanilla-ts`, `vue`, `vue-ts`, `react`, `react-ts`, `react-swc`, `react-swc-ts`, `preact`, `preact-ts`, `lit`, `lit-ts`, `svelte`, `svelte-ts`, `ember`, `ember-ts`, `solid`, `solid-ts`, `qwik`, `qwik-ts`. | |
| See [create-vite](https://github.com/vitejs/vite/tree/main/packages/create-vite) for more details on each supported template: `vanilla`, `vanilla-ts`, `vue`, `vue-ts`, `react`, `react-ts`, `react-swc`, `react-swc-ts`, `preact`, `preact-ts`, `lit`, `lit-ts`, `svelte`, `svelte-ts`, `ember-app`, `ember-app-ts`, `ember-library`, `ember-library-ts`, `solid`, `solid-ts`, `qwik`, `qwik-ts`. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Description
Ember uses Vite now, and here I've added the underlying project generating commands to vite create
This is a much smaller change than: #19564 (which adds whole template projects)