Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix Sub D #2407

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix Sub D #2407

wants to merge 1 commit into from

Conversation

chschlue
Copy link
Contributor

@chschlue chschlue commented Aug 23, 2020

pointhi/kicad-footprint-generator#584


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@myfreescalewebpage myfreescalewebpage added Enhancement Improves existing footprint in the library Pending reviewer A pull request waiting for a reviewer labels Aug 23, 2020
@cpresser
Copy link
Contributor

@chschlue chschlue linked an issue Sep 18, 2020 that may be closed by this pull request
@chschlue
Copy link
Contributor Author

Originally, this was meant to fix #2404.

I noticed the current Sub-D FPs apparently aren't generated by https://github.com/pointhi/kicad-footprint-generator/blob/master/scripts/Connectors_DSub/make_dsubs.py at all and meant to check what's going on. But then I lost track of this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing footprint in the library Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB9 Footprints do not match existing parts
3 participants