Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Missing 3Dfiles for power Led #721

Closed
wants to merge 5 commits into from
Closed

Conversation

Franck78
Copy link

@Franck78 Franck78 commented Aug 28, 2020

Created with Freecad 0.18

led1w

KiCad/kicad-footprints#2433
KiCad/kicad-symbols#2943


Thanks for creating a pull request to contribute to the KiCad libraries!
Remember you must be the legal owner of the 3D model! Models downloaded from a manufacturers website cannot be accepted.

To speed up integration of your PR, please check the following items as you complete them:

  • A screenshot of the model(s) aligned with KiCad footprint(s)
  • Source files are contributed on the apropriate location
    Source for 3D power led kicad-packages3D-source#291
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed on the model

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above).

Created with Freecad 0.18
VRML & STEP models for the Power LED 1w 3w

Tesselation settings 0.5% 20° (freecad export) to limit file size.

Todo: upload the Freecad source file
@CLAassistant
Copy link

CLAassistant commented Aug 28, 2020

CLA assistant check
All committers have signed the CLA.

For some reason the previous one was bad.
Rerun the script for FreeCad and now it"s ok
The .step was good.

Fixes: KiCad#600
@Franck78
Copy link
Author

Franck78 commented Sep 4, 2020

led+foot-top

fixes #600
The .wrl file was regenerated with the script (no edit). The .step is OK since the the beginning, no reupload needed.
led+acdc
acdc-back

@Franck78
Copy link
Author

Franck78 commented Sep 8, 2020

step file not fused.

@Franck78 Franck78 closed this Sep 8, 2020
@myfreescalewebpage myfreescalewebpage added Abandoned Original author has stopped working on the PR and removed Pending reviewer A pull request waiting for a reviewer labels Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new package 3D to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants