Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry pick 9024578 (Update gas fee controller to v11.15.2 #24520) #24549

Merged
merged 1 commit into from
May 17, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented May 16, 2024

chore: Cherry pick 9024578 (Update gas fee controller to v11.15.2 #24520)

Targeting v11.16.0.

Updates the gas fee controller to v11.15.2, so that the gas fee
controller is instantiated with the proper metadata.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24520?quickstart=1)

Fixes: #24383

1. Start a tx
2. Add recipient and amount
3. Check console, there should not be a `Error: No metadata found for
'nonRPCGasFeeApisDisabled'`

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@danjm danjm requested a review from a team as a code owner May 16, 2024 08:07
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 16, 2024
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat changed the title chore: Cherry pick 9024578 (Update gas fee controller to v11.15.2 #24520) chore: Cherry pick 9024578 (Update gas fee controller to v11.16.0 #24520) May 16, 2024
@legobeat legobeat changed the title chore: Cherry pick 9024578 (Update gas fee controller to v11.16.0 #24520) chore: Cherry pick 9024578 (Update gas fee controller to v11.15.2 #24520) May 16, 2024
@legobeat legobeat requested a review from a team May 16, 2024 08:10
@danjm danjm merged commit bdd2ecd into Version-v11.16.0 May 17, 2024
63 of 70 checks passed
@danjm danjm deleted the cherry-pick-9024578 branch May 17, 2024 14:04
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants