Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update gas fee controller to v11.15.2 #24520

Merged
merged 2 commits into from
May 15, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented May 14, 2024

Description

Updates the gas fee controller to v11.15.2, so that the gas fee controller is instantiated with the proper metadata.

Open in GitHub Codespaces

Related issues

Fixes: #24383

Manual testing steps

  1. Start a tx
  2. Add recipient and amount
  3. Check console, there should not be a Error: No metadata found for 'nonRPCGasFeeApisDisabled'

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danjm danjm requested review from a team as code owners May 14, 2024 15:32
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 14, 2024
@danjm danjm changed the title Update gas fee controller to v11.15.2 fix: Update gas fee controller to v11.15.2 May 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1600336]
Page Load Metrics (827 ± 555 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60156902311
domContentLoaded84516105
load4827318271156555
domInteractive84516105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 22.62 KiB (0.69%)
  • ui: 0 Bytes (0.00%)
  • common: -8.79 KiB (-0.14%)

brad-decker
brad-decker previously approved these changes May 14, 2024
vthomas13
vthomas13 previously approved these changes May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (01bac0c) to head (1ed1298).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24520   +/-   ##
========================================
  Coverage    67.39%   67.39%           
========================================
  Files         1289     1289           
  Lines        50210    50210           
  Branches     13005    13005           
========================================
  Hits         33837    33837           
  Misses       16373    16373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [1ed1298]
Page Load Metrics (1358 ± 690 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint661711012914
domContentLoaded9401795
load54351213581437690
domInteractive9401795
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 51 Bytes (0.00%)

@vthomas13
Copy link
Contributor

works great

@danjm danjm merged commit 9024578 into develop May 15, 2024
72 checks passed
@danjm danjm deleted the update-gas-fee-controller-15.1.2 branch May 15, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.16.0 Issue or pull request that will be included in release 11.16.0 and removed release-11.18.0 labels May 15, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.16.0 on PR. Adding release label release-11.16.0 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Gas - Error: No metadata found for 'nonRPCGasFeeApisDisabled'
4 participants