Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Snaps packages #24550

Merged
merged 4 commits into from
May 21, 2024
Merged

chore: bump Snaps packages #24550

merged 4 commits into from
May 21, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented May 16, 2024

Description

Bump snaps packages to latest and handle breaking changes.

Summary of changes in the snaps deps:

  • BREAKING: Use hooks in wallet_invokeSnap instead of remapping the request to wallet_snap
  • Add support for BIP-32-Ed25519 / CIP-3 key derivation

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label May 16, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 16, 2024
Copy link

socket-security bot commented May 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/snaps-rpc-methods@9.0.0 None 0 895 kB metamaskbot

🚮 Removed packages: npm/@noble/ed25519@1.6.0

View full report↗︎

@FrederikBolding FrederikBolding marked this pull request as ready for review May 21, 2024 17:05
@FrederikBolding FrederikBolding requested review from a team as code owners May 21, 2024 17:05
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [4d8da34]
Page Load Metrics (1518 ± 645 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint762161233919
domContentLoaded117722188
load65377115181343645
domInteractive117722188
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53.95 KiB (1.59%)
  • ui: 0 Bytes (0.00%)
  • common: 3.63 KiB (0.06%)

@FrederikBolding FrederikBolding merged commit ad3b366 into develop May 21, 2024
71 of 72 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v47 branch May 21, 2024 21:20
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants