-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
AK: Remove workarounds for missing P0960R3 support in Clang #24345
Conversation
The all red CI tells me that in fact, P0690R3 support in clang is not without bugs :D |
Have the oss-fuzz images been updated now? (ref: #22264) |
Should be, oss-fuzz is currently at Clang 17+\varepsilon version. |
Have you checked if the latest Xcode can cope with this? |
No, I don't have access to MacOS |
I patched this in and ran It failed like so:
|
Which llvm version is your Apple Clang based on? Edit: oh, cppreference says that P0960 isn't supported on Apple Clang at all. Let's then ifdef out these definition on everything except Apple Clang. (I really want to delete these because without them |
With this change, ".*make.*" function family now does error checking earlier, which improves experience while using clangd. Note that the change also make them instantiate classes a bit more eagerly, so in LibVideo/PlaybackManager, we have to first define SeekingStateHandler and only then make() it. Co-Authored-By: stelar7 <dudedbz@gmail.com>
Do you mean that the currently present workaround causes an issue with your clangd config? In that case, let's merge this. Otherwise, I don't see a point in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good justification to me, LGTM!
We'll revisit this when the next Xcode major version comes out (late August or September, I presume).
No description provided.