AK: Remove workarounds for missing P0960R3 support in Clang

[DanShaders]

No description provided.

[ADKaster]

The all red CI tells me that in fact, P0690R3 support in clang is not without bugs :D

[stelar7]

Have the oss-fuzz images been updated now? (ref: #22264)

[DanShaders]

Should be, oss-fuzz is currently at Clang 17+\varepsilon version.

[BertalanD]

Have you checked if the latest Xcode can cope with this?

[DanShaders]

No, I don't have access to MacOS

[nico]

I patched this in and ran Meta/serenity.sh build lagom image on a mac with Xcode 15.2. That's the newest version that runs on macOS 13.5+ (I haven't installed macOS 14 yet), but not the very newest version (which is 15.4).

It failed like so:

[153/283] Building CXX object Userland/Libraries/LibGfx/CMakeFiles/LibGfx.dir/ImageFormats/TinyVGLoader.cpp.o
FAILED: Userland/Libraries/LibGfx/CMakeFiles/LibGfx.dir/ImageFormats/TinyVGLoader.cpp.o 
/Users/thakis/Downloads/ccache-4.9-darwin/ccache /usr/bin/clang++ -DENABLE_COMPILETIME_FORMAT_CHECK -DLibGfx_EXPORTS -I/Users/thakis/src/serenity/Meta/Lagom/../.. -I/Users/thakis/src/serenity/Meta/Lagom/../../Userland -I/Users/thakis/src/serenity/Meta/Lagom/../../Userland/Libraries -I/Users/thakis/src/serenity/Meta/Lagom/../../Userland/Services -I/Users/thakis/src/serenity/Build/lagom -I/Users/thakis/src/serenity/Build/lagom/Userland/Libraries -I/Users/thakis/src/serenity/Build/lagom/Userland/Services -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk -mmacosx-version-min=13.5 -fPIC -fcolor-diagnostics -Wall -Wextra -Wno-invalid-offsetof -Wno-unknown-warning-option -Wno-unused-command-line-argument -fno-exceptions -ffp-contract=off -Werror -fconstexpr-steps=16777216 -Wno-implicit-const-int-float-conversion -Wno-user-defined-literals -Wno-vla-cxx-extension -Wno-maybe-uninitialized -Wno-shorten-64-to-32 -fsigned-char -ggnu-pubnames -fPIC -O2 -g1 -Wno-overloaded-virtual -Wno-unused-private-field -std=c++2b -MD -MT Userland/Libraries/LibGfx/CMakeFiles/LibGfx.dir/ImageFormats/TinyVGLoader.cpp.o -MF Userland/Libraries/LibGfx/CMakeFiles/LibGfx.dir/ImageFormats/TinyVGLoader.cpp.o.d -o Userland/Libraries/LibGfx/CMakeFiles/LibGfx.dir/ImageFormats/TinyVGLoader.cpp.o -c /Users/thakis/src/serenity/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.cpp
/Users/thakis/src/serenity/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.cpp:549:19: error: no matching function for call to 'make'
    : m_context { make<TinyVGLoadingContext>(FixedMemoryStream { bytes }) }
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/thakis/src/serenity/Meta/Lagom/../../AK/NonnullOwnPtr.h:148:63: note: candidate template ignored: constraints not satisfied [with T = Gfx::TinyVGLoadingContext, Args = <AK::FixedMemoryStream>]
requires(IsConstructible<T, Args...>) inline NonnullOwnPtr<T> make(Args&&... args)
                                                              ^
/Users/thakis/src/serenity/Meta/Lagom/../../AK/NonnullOwnPtr.h:148:10: note: because 'IsConstructible<Gfx::TinyVGLoadingContext, AK::FixedMemoryStream>' evaluated to false
requires(IsConstructible<T, Args...>) inline NonnullOwnPtr<T> make(Args&&... args)
         ^
1 error generated.

[DanShaders]

Which llvm version is your Apple Clang based on?

Edit: oh, cppreference says that P0960 isn't supported on Apple Clang at all. Let's then ifdef out these definition on everything except Apple Clang. (I really want to delete these because without them make gives an error inline in clangd)

[BertalanD]

I really want to delete these because without them make gives an error inline in clangd

Do you mean that the currently present workaround causes an issue with your clangd config? In that case, let's merge this. Otherwise, I don't see a point in #ifdef-ing out the code right now.

[DanShaders]

It doesn't really work around any issues, just makes life easier, i. e.:

Before:

+ some long error when compiling

After:

[BertalanD]

Sounds like a good justification to me, LGTM!

We'll revisit this when the next Xcode major version comes out (late August or September, I presume).