fix(zone.js): do not mutate event listener options (may be readonly) #55796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
force-pushed
the
fix/54142-zone-ac
branch
from
5dbe16b
to
29cfe68
Compare
arturovt
force-pushed
the
fix/54142-zone-ac
branch
3 times, most recently
from
651aea4
to
2b8f010
Compare
AndrewKushnir
added
action: review
AndrewKushnir
added
the
target: patch
pullapprove
bot
added
target: patch
AndrewKushnir
added
requires: TGP
pullapprove
bot
removed
requires: TGP
AndrewKushnir
added
the
requires: TGP
pullapprove
bot
removed
the
requires: TGP
AndrewKushnir
added
the
action: global presubmit
Prior to this commit, event listener options were mutated directly, for example, `options.signal = undefined` or `options.once = false`. This issue arises in apps using third-party libraries where the responsibility lies with the library provider. Some libraries, like WalletConnect, pass an abort controller as `addEventListener` options. Because the abort controller has the `signal` property, this is a valid case. Thus, mutating options would throw an error since `signal` is a readonly property. Even though zone.js is being deprecated as Angular moves towards zoneless change detection, this fix is necessary for apps that still use zone.js and cannot migrate to zoneless change detection because they rely on third-party libraries and are not responsible for the code used in them. Closes angular#54142
arturovt
force-pushed
the
fix/54142-zone-ac
branch
from
2b8f010
to
6679674
Compare
AndrewKushnir
added
action: merge
|
Caretaker note: TGP is "green" (except for unrelated build breakages), this PR is ready for merge. |
|
This PR was merged into the repository by commit 85c1719. |
dylhunn
pushed a commit
that referenced
this pull request
May 22, 2024
…55796) Prior to this commit, event listener options were mutated directly, for example, `options.signal = undefined` or `options.once = false`. This issue arises in apps using third-party libraries where the responsibility lies with the library provider. Some libraries, like WalletConnect, pass an abort controller as `addEventListener` options. Because the abort controller has the `signal` property, this is a valid case. Thus, mutating options would throw an error since `signal` is a readonly property. Even though zone.js is being deprecated as Angular moves towards zoneless change detection, this fix is necessary for apps that still use zone.js and cannot migrate to zoneless change detection because they rely on third-party libraries and are not responsible for the code used in them. Closes #54142 PR Close #55796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, event listener options were mutated directly, for example,
options.signal = undefinedoroptions.once = false.This issue arises in apps using third-party libraries where the responsibility lies
with the library provider. Some libraries, like WalletConnect, pass an abort controller
as
addEventListeneroptions. Because the abort controller has thesignalproperty,this is a valid case. Thus, mutating options would throw an error since
signalis a readonly property.
Even though zone.js is being deprecated as Angular moves towards zoneless change detection,
this fix is necessary for apps that still use zone.js and cannot migrate to zoneless change
detection because they rely on third-party libraries and are not responsible for the code
used in them.
Closes #54142