Revert -Wformat for scoped enums #8638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stics (llvm#67378)" This reverts commit 69c8c96.
This reverts commit 3632e2f.
krispymb
approved these changes
Apr 24, 2024
|
@swift-ci please test |
fahadnayyar
approved these changes
Apr 26, 2024
drodriguez
reviewed
May 2, 2024
| @@ -12,33 +12,21 @@ struct S { | |||
| N::E Type; | |||
| }; | |||
|
|
|||
| using uint32_t = unsigned; | |||
| enum class FixedE : uint32_t { Two }; | |||
|
|
|||
| void a(N::E NEVal, S *SPtr, S &SRef) { | |||
| printf("%d", N::E::One); // expected-warning{{format specifies type 'int' but the argument has type 'N::E'}} | |||
There was a problem hiding this comment.
Were these expected-warning necessary on the Apple CI after the changes?
They seem to be failing in every configuration when we pick up this change in our CI.
I noticed that there was no "please test llvm" in this change, so the LLVM/Clang tests were not executed in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The covered diagnostic change hadn't landed yet in an Apple compiler release.
During qualification, we ran into the fact that the
os_logAPIs force-Wformatto an error, and this causes a lot of churn for users dealing with this. There's some discussion upstream about what exactly the behavior of this diagnostic should be, and we're not ready to ship this.This reverts the
-Wformatchange for scoped enums for this release.For later releases, this diagnostic is moved to
-Wformat-pedanticwhich shouldn't run into the same adoption issues. See: llvm#88595