Add SwiftDriver dependency to SKSwiftPMWorkspace
#1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In apple/swift-package-manager#7258 we need to use `SwiftDriver` explicitly to make sure that `package` access modifier and `-package-name` support can be detected properly. Somehow this dependency needs to be propagate to everyone depending `SourceKitLSPAPI`, even though the dependency was added as `PRIVATE` in SwiftPM. Adding it as `PRIVATE` here too.
ahoppen
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In apple/swift-package-manager#7258 we need to use
SwiftDriverexplicitly to make sure thatpackageaccess modifier and-package-namesupport can be detected properly. Somehow this dependency needs to be propagate to everyone dependingSourceKitLSPAPI, even though the dependency was added asPRIVATEin SwiftPM. Adding it asPRIVATEhere too.