Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SwiftDriver dependency to SKSwiftPMWorkspace #1061

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add SwiftDriver dependency to SKSwiftPMWorkspace #1061

wants to merge 3 commits into from

Commits on Feb 17, 2024

  1. Add SwiftDriver dependency to SKSwiftPMWorkspace 

    In apple/swift-package-manager#7258 we need to use `SwiftDriver` explicitly to make sure that `package` access modifier and `-package-name` support can be detected properly. Somehow this dependency needs to be propagate to everyone depending `SourceKitLSPAPI`, even though the dependency was added as `PRIVATE` in SwiftPM. Adding it as `PRIVATE` here too.
    @MaxDesiatov
    MaxDesiatov committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    1b6963a View commit details
    Browse the repository at this point in the history

  2. Update CMakeLists.txt

    @MaxDesiatov
    MaxDesiatov committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    cce861e View commit details
    Browse the repository at this point in the history

  3. Add find_package(SwiftDriver CONFIG REQUIRED) to CMakeLists.txt

    @MaxDesiatov
    MaxDesiatov committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    bd5e7d5 View commit details
    Browse the repository at this point in the history