Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arena to syntax nodes #2078

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add arena to syntax nodes #2078

wants to merge 2 commits into from

Conversation

kimdv
Copy link
Collaborator

@kimdv kimdv commented Aug 16, 2023 •
edited

Resolves #2036

Open this PR to start discussion and getting help when needed.

ahoppen
ahoppen reviewed Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I’d like to see a whole PR that improves the performance of SyntaxRewriter before merging any of the piece PRs, just to make sure we’re going in the right direction.

@kimdv
Copy link
Collaborator Author

kimdv commented Aug 16, 2023

This looks good to me but I’d like to see a whole PR that improves the performance of SyntaxRewriter before merging any of the piece PRs, just to make sure we’re going in the right direction.

This not done yet.
But I wanted to open the PR so I can get help if needed.
It's easier to explain here on GitHub 😁

@ahoppen
Copy link
Collaborator

ahoppen commented Aug 16, 2023

Yeah, I totally agree. Just wanted to comment that we shouldn’t merge this as-is.

@kimdv kimdv force-pushed the kimdv/2036-improve-syntaxrewriter-performance-for-operator-folding branch 2 times, most recently from d2d2ae3 to e5265b5 Compare August 21, 2023 20:40
@kimdv kimdv force-pushed the kimdv/2036-improve-syntaxrewriter-performance-for-operator-folding branch from e5265b5 to 48f514b Compare September 14, 2023 18:59
@kimdv kimdv force-pushed the kimdv/2036-improve-syntaxrewriter-performance-for-operator-folding branch from 48f514b to 18f51a4 Compare September 14, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen left review comments

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham will be requested when the pull request is marked ready for review bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve SyntaxRewriter performance for operator folding
2 participants
@kimdv @ahoppen