New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DebugInfo] Improve documentation & Fix discovered bugs #73276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowy1803
force-pushed
the
doc-and-fixes
branch
from
April 26, 2024 01:01
32307a9
to
28a7b09
Compare
@swift-ci please test |
@swift-ci please test source compatibility |
Snowy1803
force-pushed
the
doc-and-fixes
branch
2 times, most recently
from
April 26, 2024 19:19
ea41bbb
to
655de5c
Compare
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent update to the documentation!
The optimizer and IRGen changes look good!
I have a few minor wording suggestions inline.
Snowy1803
force-pushed
the
doc-and-fixes
branch
from
April 26, 2024 23:28
a4117e1
to
03ef685
Compare
Snowy1803
force-pushed
the
doc-and-fixes
branch
from
April 26, 2024 23:31
03ef685
to
16c57ae
Compare
@swift-ci please test |
adrian-prantl
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more documentation about updating debug values, and debug value expressions.
Fixes a few bugs: undef debug values being removed, constant debug values not working, arithmetic without a deref not working.
Add support for salvaging integer literals.
This increases the number of debug variables in the standard library by 1.7%
The biggest improvements in the amount of lost variables are: constant propagation (-81%), sil combine (-50%), dead code elimination (-31%), copy propagation (-59%), common subexpression elimination (-24%)