-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set daemon pod failed when exit with a non-zero status. Fixes:#12911 #12988
base: main
Are you sure you want to change the base?
Conversation
2ac9757
to
1724e0b
Compare
91f43b6
to
7dd8b0e
Compare
/retest |
…j#12911 Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun <tsk2013uestc@163.com>
WithField("pod", pod.Name).Infof("Pod failed: %s", new.Message) | ||
} | ||
new.Phase, new.Message = woc.inferFailedReason(pod, tmpl) | ||
woc.log.WithField("displayName", old.DisplayName).WithField("templateName", old.TemplateName).WithField("pod", pod.Name).Infof("Pod failed: %s", new.Message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like somebody explicitly thought that Daemons should never been in a Failed state. Do we understand why?
It appears that this was by design that the Workflow and Node should succeed even if the Daemon failed. I wonder if it should be configurable in the ConfigMap and/or Workflow if perhaps some users want the opposite? |
Yes I can try that. |
Fixes #12911
Motivation
set daemon pod failed when exit with a non-zero status
Modifications
Verification