-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daemon pod is always succeeded even with a non-zero status code #12911
Comments
The current design indeed ignores daemon failed. argo-workflows/workflow/controller/operator.go Line 1336 in 934bf17
|
@shuangkun |
We also have a similar issue, how we can catch daemon failure via hook to send notifications? We have the same in DAG templates. |
…j#12911 Signed-off-by: shuangkun <tsk2013uestc@163.com>
…j#12911 Signed-off-by: shuangkun <tsk2013uestc@163.com>
…j#12911 Signed-off-by: shuangkun <tsk2013uestc@163.com>
…j#12911 Signed-off-by: shuangkun <tsk2013uestc@163.com>
…j#12911 Signed-off-by: shuangkun <tsk2013uestc@163.com>
…j#12911 Signed-off-by: shuangkun <tsk2013uestc@163.com>
FYI, just added this comment in the PR: #12988 (comment) |
Pre-requisites
:latest
What happened/what did you expect to happen?
Daemon pod is always succeeded even with a non-zero status code, I expect to find the daemon step failed, then the workflow as well.
Version
v3.5.5
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: