Add <named-color> to CSSParser #44623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57553237 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
May 20, 2024
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Differential Revision: D57553237
jorge-cab
force-pushed
the
export-D57553237
branch
from
3f0d4b4
to
8d7f36c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57553237 |
Base commit: 9dfcb9e |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
May 20, 2024
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Differential Revision: D57553237
jorge-cab
force-pushed
the
export-D57553237
branch
from
8d7f36c
to
4670f15
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57553237 |
jorge-cab
force-pushed
the
export-D57553237
branch
from
4670f15
to
7ce8780
Compare
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
May 21, 2024
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Differential Revision: D57553237
|
This pull request was exported from Phabricator. Differential Revision: D57553237 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
May 21, 2024
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Differential Revision: D57553237
jorge-cab
force-pushed
the
export-D57553237
branch
from
7ce8780
to
9b72572
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57553237 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
May 21, 2024
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Differential Revision: D57553237
jorge-cab
force-pushed
the
export-D57553237
branch
from
9b72572
to
2a0b139
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57553237 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
May 21, 2024
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D57553237
jorge-cab
force-pushed
the
export-D57553237
branch
from
2a0b139
to
1d21ef1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57553237 |
Summary: The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and convert the ident into hex. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D57553237
jorge-cab
force-pushed
the
export-D57553237
branch
from
1d21ef1
to
58e5435
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57553237 |
|
This pull request has been merged in 494c86e. |
|
This pull request was successfully merged by @jorge-cab in 494c86e. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44623 The syntax for <color> is defined as (https://www.w3.org/TR/css-color-4/#color-syntax): ``` <color> = <color-base> | currentColor | <system-color> <color-base> = <hex-color> | <color-function> | <named-color> | transparent <color-function> = <rgb()> | <rgba()> | <hsl()> | <hsla()> | <hwb()> | <lab()> | <lch()> | <oklab()> | <oklch()> | <color()> ``` This diff implements in particular: ``` <color-base> = <named-color> ``` We create a map containing all hex value representations of each named color and directly return the RGBA Values Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D57553237 fbshipit-source-id: 7b5bbaf77424cc4a4c833d107ef89601f9fcd9a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The syntax for is defined as (https://www.w3.org/TR/css-color-4/#color-syntax):
This diff implements in particular:
We create a map containing all hex value representations of each named color and convert the ident into hex.
Changelog: [Internal]
Differential Revision: D57553237