Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Generate object previews for live console messages
Summary: Changelog: [Internal] bypass-github-export-checks Currently, Hermes never generates object/array previews for values logged via the `console` API. This makes console logs significantly less readable than in Chrome. Here we enable the preview generation machinery that already exists in Hermes. We conservatively mimic V8's behaviour of [only generating previews for immediately-emitted messages](https://source.chromium.org/chromium/chromium/src/+/main:v8/src/inspector/v8-console-agent-impl.cc;l=53,64;drc=451a101b0a8bbc323dbf5697dd956b55284ec9ee) and not for buffered messages. I don't know *why* V8 does this, but can only guess it's meant to improve the performance of starting a debugging session, by evaluating less code and sending smaller payloads. (Anyway, we can change our decision later.) Reviewed By: dannysu Differential Revision: D57617059 fbshipit-source-id: 1f5a71ce98ac915a5b874ed6c009d971405a9f2d
- Loading branch information