Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(jsdoc): Server-Timing Middleware #2703

Merged

Conversation

goisaki
Copy link
Contributor

@goisaki goisaki commented May 18, 2024

This PR is to add JSDoc for Server-Timing Middleware.
Note that the target of the PR is not main.

Related:

@goisaki goisaki mentioned this pull request May 18, 2024
16 tasks
@goisaki goisaki force-pushed the docs/jsdoc-middleware-timing branch from 4cd5eb9 to c1793db Compare May 18, 2024 05:50
@goisaki goisaki force-pushed the docs/jsdoc-middleware-timing branch from 1e38b6c to e4dfb5a Compare May 19, 2024 12:00
feat: add missed jsdoc

fix: fix type
@goisaki goisaki force-pushed the docs/jsdoc-middleware-timing branch from e4dfb5a to d1a2949 Compare May 19, 2024 12:09
@goisaki
Copy link
Contributor Author

goisaki commented May 19, 2024

Hi @yusukebe
Currently, the change to remove Partial is made only in JSDoc. To include these changes in the code, we need to merge honojs:main into honojs:docs/jsdoc-middleware.

(It is possible to do this merge in this PR, but it is not recommended because it will include out-of-scope changes.)

@yusukebe
Copy link
Member

Hi @goisaki !

You are right! But, I've merged the main to docs/jsdoc-middleware and merged it to your branch. It's okay. I'll merge this now. Thanks!

@yusukebe yusukebe merged commit 50e96ba into honojs:docs/jsdoc-middleware May 21, 2024
yusukebe added a commit that referenced this pull request May 24, 2024
feat: add missed jsdoc

fix: fix type

Co-authored-by: Yusuke Wada <yusuke@kamawada.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants