Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test framework: remove "Static VM" concept #51036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

howardjohn
Copy link
Member

This is part of an overall goal to reduce the complexity of the test framework, to ease debugging, test writing, and improving the framework in other ways.

This removes the concept of non-Kubernetes clusters. These were used to build out real VM instances, rather than the in-pod simulation ones. However, I don't think anyone uses this.

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label May 14, 2024
@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 14, 2024
@howardjohn
Copy link
Member Author

/test all

@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR needs to be rebased before being merged labels May 14, 2024
@bleggett
Copy link
Contributor

bleggett commented May 16, 2024

Okay I didn't realize this would kill about 2K LOC. +1 then.

@howardjohn howardjohn marked this pull request as ready for review May 16, 2024 18:40
@howardjohn howardjohn requested review from a team as code owners May 16, 2024 18:40
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 16, 2024
Copy link
Contributor

@bleggett bleggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per 5/15 WG consensus.

@jwendell
Copy link
Member

does the readme need to be updated?

Copy link
Contributor

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks John!

@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label May 16, 2024
@howardjohn
Copy link
Member Author

does the readme need to be updated?

I don't know any readme that references this?

@howardjohn
Copy link
Member Author

@istio/wg-test-and-release-maintainers LFR

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label May 20, 2024
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing
Copy link
Collaborator

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integ-basic-arm64_istio 792e9f9 link unknown /test integ-basic-arm64
unit-tests-arm64_istio 792e9f9 link unknown /test unit-tests-arm64
integ-distroless_istio 792e9f9 link unknown /test integ-distroless
integ-cni_istio 792e9f9 link unknown /test integ-cni
gencheck_istio 792e9f9 link unknown /test gencheck
integ-ambient_istio 792e9f9 link unknown /test integ-ambient
integ-ipv6_istio 792e9f9 link unknown /test integ-ipv6
integ-helm_istio 792e9f9 link unknown /test integ-helm
integ-ds_istio 792e9f9 link unknown /test integ-ds
unit-tests_istio 792e9f9 link unknown /test unit-tests
integ-operator-controller_istio 792e9f9 link unknown /test integ-operator-controller
integ-security_istio 792e9f9 link unknown /test integ-security
integ-telemetry-discovery_istio 792e9f9 link unknown /test integ-telemetry-discovery
integ-pilot_istio 792e9f9 link unknown /test integ-pilot
macbuildcheck_istio 792e9f9 link unknown /test macbuildcheck
release-notes_istio 792e9f9 link unknown /test release-notes
integ-telemetry-mc_istio 792e9f9 link unknown /test integ-telemetry-mc
lint_istio 792e9f9 link unknown /test lint
integ-pilot-istiodremote_istio 792e9f9 link unknown /test integ-pilot-istiodremote
integ-pilot-istiodremote-mc_istio 792e9f9 link unknown /test integ-pilot-istiodremote-mc
integ-security-multicluster_istio 792e9f9 link unknown /test integ-security-multicluster
integ-telemetry-istiodremote_istio 792e9f9 link unknown /test integ-telemetry-istiodremote
integ-telemetry_istio 792e9f9 link unknown /test integ-telemetry
integ-security-istiodremote_istio 792e9f9 link unknown /test integ-security-istiodremote
release-test_istio 792e9f9 link unknown /test release-test
integ-pilot-multicluster_istio 792e9f9 link unknown /test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants