-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test framework: remove "Static VM" concept #51036
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
/test all |
Okay I didn't realize this would kill about 2K LOC. +1 then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per 5/15 WG consensus.
does the readme need to be updated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM, thanks John!
fed7c37
to
792e9f9
Compare
I don't know any readme that references this? |
@istio/wg-test-and-release-maintainers LFR |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@howardjohn: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is part of an overall goal to reduce the complexity of the test framework, to ease debugging, test writing, and improving the framework in other ways.
This removes the concept of non-Kubernetes clusters. These were used to build out real VM instances, rather than the in-pod simulation ones. However, I don't think anyone uses this.