Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add time remaining before cert expires metrics #51076

Merged
merged 2 commits into from
May 21, 2024
Merged

add time remaining before cert expires metrics #51076

merged 2 commits into from
May 21, 2024

Conversation

whitneygriffith
Copy link
Contributor

@whitneygriffith whitneygriffith commented May 15, 2024 •
edited by istio-policy-bot

Please provide a description of this PR:

Resolves #51037

@whitneygriffith
add time remaining before cert expires metrics
c020cb7 
Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
@whitneygriffith whitneygriffith requested a review from a team as a code owner May 15, 2024 19:39
@istio-policy-bot istio-policy-bot added the release-notes-none Indicates a PR that does not require release notes. label May 15, 2024
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2024
@whitneygriffith whitneygriffith added do-not-merge Block automatic merging of a PR. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2024
@whitneygriffith whitneygriffith removed the do-not-merge Block automatic merging of a PR. label May 15, 2024
@whitneygriffith
Copy link
Contributor Author

PTAL @jaellio @howardjohn

jaellio
jaellio reviewed May 16, 2024
View reviewed changes
security/pkg/server/ca/monitoring.go Outdated Show resolved Hide resolved
security/pkg/pki/util/keycertbundle.go Outdated Show resolved Hide resolved
@hzxuzhonghu hzxuzhonghu added the do-not-merge/hold Block automatic merging of a PR. label May 17, 2024
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2024
@whitneygriffith
use the derived gauge metric type
82d6197 
Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
hzxuzhonghu
hzxuzhonghu approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@whitneygriffith whitneygriffith removed the do-not-merge/hold Block automatic merging of a PR. label May 21, 2024
@istio-testing istio-testing merged commit e387290 into istio:master May 21, 2024
28 checks passed
@whitneygriffith whitneygriffith deleted the citadel-metrics branch May 21, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@zirain zirain zirain approved these changes

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@jaellio jaellio Awaiting requested review from jaellio

Assignees

@jaellio jaellio

Labels
release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert citadel cert expiry timestamp metrics to citadel cert expiry time left
8 participants
@whitneygriffith @howardjohn @zirain @hzxuzhonghu @jaellio @keithmattix @istio-testing @istio-policy-bot