Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up testing environment for gateway api #11179

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

strongjz
Copy link
Member

add mage testing framework for local gateway api testing, with metallb for loadbalancer.

Signed-off-by: James Strong <strong.james.e@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 29, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2024
Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit b7290e4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66099b263015890008041063

Comment on lines 43 to 54
if ARCH != runtime.GOARCH {
ARCH = runtime.GOARCH
}

COMMIT_SHA, err := getCommitSHA()
utils.CheckIfError(err, "Error Getting Commit sha")

err = sh.RunV("docker", "build",
"--no-cache",
"--build-arg", fmt.Sprintf("BASE_IMAGE=%s", BASE_IMAGE),
"--build-arg", fmt.Sprintf("VERSION=%s", TAG),
"--build-arg", fmt.Sprintf("TARGETARCH=%s", ARCH),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you are trying to override the ARCH, you can drop the if block here and assignment and use the runtime arch directly

Suggested change
if ARCH != runtime.GOARCH {
ARCH = runtime.GOARCH
}
COMMIT_SHA, err := getCommitSHA()
utils.CheckIfError(err, "Error Getting Commit sha")
err = sh.RunV("docker", "build",
"--no-cache",
"--build-arg", fmt.Sprintf("BASE_IMAGE=%s", BASE_IMAGE),
"--build-arg", fmt.Sprintf("VERSION=%s", TAG),
"--build-arg", fmt.Sprintf("TARGETARCH=%s", ARCH),
COMMIT_SHA, err := getCommitSHA()
utils.CheckIfError(err, "Error Getting Commit sha")
err = sh.RunV("docker", "build",
"--no-cache",
"--build-arg", fmt.Sprintf("BASE_IMAGE=%s", BASE_IMAGE),
"--build-arg", fmt.Sprintf("VERSION=%s", TAG),
"--build-arg", fmt.Sprintf("TARGETARCH=%s", runtime.GOARCH),

Copy link
Member Author

@strongjz strongjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, i could, had the default arm 64 but forgot metallb doesn't work with docker for Mac so had to go Linux server.

Signed-off-by: James Strong <strong.james.e@gmail.com>
Signed-off-by: James Strong <strong.james.e@gmail.com>
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label May 26, 2024
@k8s-triage-robot
Copy link

The lifecycle/frozen label can not be applied to PRs.

This bot removes lifecycle/frozen from PRs because:

  • Commenting /lifecycle frozen on a PR has not worked since March 2021
  • PRs that remain open for >150 days are unlikely to be easily rebased

You can:

  • Rebase this PR and attempt to get it merged
  • Close this PR with /close

Please send feedback to sig-contributor-experience at kubernetes/community.

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants