Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PrivateRegistry from test suite and some e2e tests that depend on it #124875

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove PrivateRegistry from test suite and some e2e tests that depend on it #124875

wants to merge 1 commit into from

Conversation

dims
Copy link
Member

@dims dims commented May 14, 2024 •
edited

Related to #97026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

manifest of list of registries for e2e test suite no longer needs a private registry

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 14, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 14, 2024
@dims dims mentioned this pull request May 14, 2024
Open
@dims dims force-pushed the remove-private-registry-from-test-suite branch from c94bd06 to b0c236e Compare May 14, 2024 23:40
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2024
@dims
Copy link
Member Author

dims commented May 15, 2024

/sig apps

@dims
Copy link
Member Author

dims commented May 15, 2024

/assign @soltysh @SergeyKanzhelev

@dims dims changed the title Remove PrivateRegistry from test suite Remove PrivateRegistry from test suite and some e2e tests that depend on it May 15, 2024
@dims
Copy link
Member Author

dims commented May 15, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
soltysh
soltysh approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from sig-apps pov

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member Author

dims commented May 15, 2024

/assign @BenTheElder @aojea

@dims dims force-pushed the remove-private-registry-from-test-suite branch from b0c236e to 168ed85 Compare May 15, 2024 18:03
@dims
Remove PrivateRegistry from test suite
232c0bc 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the remove-private-registry-from-test-suite branch from 168ed85 to 232c0bc Compare May 15, 2024 18:05
@k8s-ci-robot
Copy link
Contributor

@dims: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-verify 232c0bc link true /test pull-kubernetes-verify
pull-kubernetes-unit 232c0bc link true /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

SergeyKanzhelev
SergeyKanzhelev reviewed May 15, 2024
View reviewed changes
test/e2e/common/node/image_credential_provider.go
@@ -1,69 +0,0 @@
/*
Copyright 2022 The Kubernetes Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndixita is there any other tests covering creds provider e2e?

/hold

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are no other tests covering the credential provider.

@haircommander haircommander moved this from Triage to PRs Waiting on Author in SIG Node CI/Test Board May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@ndixita ndixita ndixita left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@soltysh soltysh soltysh approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@soltysh soltysh

@BenTheElder BenTheElder

@aojea aojea

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Apps
Status: Needs Triage
SIG Node CI/Test Board
PRs Waiting on Author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dims @k8s-ci-robot @soltysh @BenTheElder @ndixita @SergeyKanzhelev @aojea