Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate private registry e2e tests away from gcr.io/k8s-authenticated-test #97026

Open
spiffxp opened this issue Dec 2, 2020 · 29 comments
Open
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@spiffxp
Copy link
Member

spiffxp commented Dec 2, 2020

Part of umbrella to migrate kubernetes e2e test images/registries to community-owned infrastructure: kubernetes/k8s.io#1458

Followup to #97002

The registry is used by the following kubernetes e2e tests:

  • [sig-apps] ReplicaSet should serve a basic image on each replica with a private image
  • [sig-apps] ReplicationController should serve a basic image on each replica with a private image

kubernetes/k8s.io#1459 covers setting up a community-owned alternative

This issue covers updating the tests. Fixes may need to be cherry-picked back to previous release branches.

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 2, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Dec 2, 2020

/sig apps
test owner
/sig testing
/sig release
/area release-eng
/wg k8s-infra

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject wg/k8s-infra and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 2, 2020
@spiffxp spiffxp added this to the v1.21 milestone Dec 2, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Dec 3, 2020

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 3, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Dec 4, 2020

It's worth reconsidering whether these test have value as currently written

ginkgo.It("should serve a basic image on each replica with a private image", func() {
// requires private images
e2eskipper.SkipUnlessProviderIs("gce", "gke")
privateimage := imageutils.GetConfig(imageutils.AgnhostPrivate)
TestReplicationControllerServeImageOrFail(f, "private", privateimage.GetE2EImage())
})
:

  • if someone mirror this image into a public registry, they'll still pass
  • they don't run unless the e2e test framework's provider is gce or gke; practically speaking this is only going to run against clusters created by cluster/kube-up.sh

I would be in favor of deleting the tests. They're testing out that a cluster's nodes have been configured to pull from a known private registry, without the use of ImagePullSecrets. That's pretty cluster-implementation-specific.

@spiffxp
Copy link
Member Author

spiffxp commented Jan 21, 2021

/sig node
I think node may be a more appropriate test owner for this functionality if we decide we want the test to stick around

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 21, 2021
@spiffxp spiffxp added this to Needs Triage in sig-k8s-infra via automation Feb 8, 2021
@spiffxp spiffxp moved this from Needs Triage to Backlog (infra to migrate) in sig-k8s-infra Feb 8, 2021
@spiffxp spiffxp added this to To Triage in sig-testing issues Feb 9, 2021
@desponda
Copy link

desponda commented Mar 8, 2021

@spiffxp do you know if this is still targeted to 1.21 Milestone?

@spiffxp
Copy link
Member Author

spiffxp commented Mar 8, 2021

Yes. This is subject to Test Freeze, not Code Freeze. If we find it's unreasonable to land by then, I'll push to next cycle.

@palnabarun
Copy link
Member

@spiffxp -- friendly heads up, Tomorrow March 24th Wednesday is the v1.21 Test Freeze. :)

@spiffxp
Copy link
Member Author

spiffxp commented Mar 24, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Mar 26, 2022
@harshitasao
Copy link

Hi @spiffxp, k8s 1.25 Bug Triage Shadow here, just checking in to see if this is still on track for k8s 1.25?
Thank you.

@harshitasao
Copy link

Hi, just checking in to see if this is still on track for k8s 1.25?
Thanks!

@helayoty
Copy link
Member

@dims 👋 the release 1.25 bug triage Lead. I'm reaching out to see the status of this issue and if we are still targeting the current release.

@dims
Copy link
Member

dims commented Aug 15, 2022

/milestone v1.26

kick the can down the road yet again!

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.25, v1.26 Aug 15, 2022
@salaxander
Copy link

Hey @dims and @spiffxp - 1.26 bug triage team here! Just wanted to check in and see how we're looking for this release?

Thanks!

@dims
Copy link
Member

dims commented Oct 4, 2022

/milestone v1.27

kick the can down the road yet again! :) thanks for the ping @salaxander

@k8s-ci-robot
Copy link
Contributor

@dims: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.16, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to this:

/milestone v1.27

kick the can down the road yet again! :) thanks for the ping @salaxander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leonardpahlke leonardpahlke removed this from the v1.26 milestone Nov 9, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2023
@furkatgofurov7
Copy link
Member

Hey @spiffxp - 1.27 Bug Triage Team Shadow here!

Just wanted to check if this is still on track for 1.27 release?

Thanks!

@dims: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.16, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

@dims Hi! Looks like the milestone was not properly applied in your previous comment, should we re-apply it?

Thanks!

@dims
Copy link
Member

dims commented Feb 20, 2023

@furkatgofurov7 let's leave it as-is (not apply milestone at all)

@k8s-triage-robot
Copy link

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged.
Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 21, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 20, 2023
@BenTheElder BenTheElder added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 15, 2023
@k8s-triage-robot
Copy link

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged.
Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
Status: Backlog
Status: Pending inclusion
sig-k8s-infra
  
Backlog (infra to migrate)