Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet/cm/cpumanager: Improving test coverage #124897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kubelet/cm/cpumanager: Improving test coverage #124897

wants to merge 1 commit into from

Conversation

TommyStarK
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

If applied this commit will improve the unit testing coverage of pkg/kubelet/cm/cpumanager.

  • before
Screenshot 2024-05-15 at 22 49 21
  • after
Screenshot 2024-05-15 at 22 49 02

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TommyStarK
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 15, 2024
@TommyStarK
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

ffromani
ffromani reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/priority backlog

pkg/kubelet/cm/cpumanager/state/state_checkpoint_test.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/state/state_checkpoint_test.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/topology/topology_test.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/topology/topology_test.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/topology/topology_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 16, 2024
@TommyStarK TommyStarK force-pushed the unit-tests/pkg-kubelet-cm-cpumanager branch from 2f38a6e to 512ca4b Compare May 16, 2024 07:30
@TommyStarK
Copy link
Contributor Author

Thank you very much for the review @ffromani and sorry for the irrelevance of the tests, I lack a lot of knowledge on this topic

@ffromani
Copy link
Contributor

Thank you very much for the review @ffromani and sorry for the irrelevance of the tests, I lack a lot of knowledge on this topic

No worries, tests are well intentioned, we just need to coordinate with all the flying PRs

@TommyStarK
kubelet/cm/cpumanager: Improving test coverage
1b536fd 
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
@TommyStarK TommyStarK force-pushed the unit-tests/pkg-kubelet-cm-cpumanager branch from 512ca4b to 1b536fd Compare May 16, 2024 08:10
@bart0sh bart0sh added this to Needs Reviewer in SIG Node PR Triage May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@klueska klueska Awaiting requested review from klueska

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees
No one assigned
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Status: Needs Reviewer
SIG Node PR Triage
Needs Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TommyStarK @k8s-ci-robot @ffromani