fix: relative non_zeroes calc

laresbernardo · May 13, 2024 · 3f1438b · 3f1438b
1 parent da7acfe
commit 3f1438b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/R/robyn.R b/R/robyn.R
@@ -235,8 +235,9 @@ robyn_modelselector <- function(
     group_by(.data$solID) %>%
     summarise(
       performance = sum(.data$xDecompAgg)/sum(.data$total_spend) - 1,
-      non_zeroes = (1 - length(.data$rn[
-        which(round(.data$coef, 6) == 0) & .data$rn %in% InputCollect$all_media])),
+      non_zeroes = length(.data$rn[
+        round(.data$coef, 6) == 0 & .data$rn %in% InputCollect$all_media]) /
+        length(InputCollect$all_media),
       top_channels = paste(.data$rn[head(rank(-.data$roi_total, ties.method = "first"), 3)], collapse = ", "),
       zero_coef = paste(.data$rn[which(round(.data$coef, 6) == 0)], collapse = ", ")) %>%
     left_join(potOpt, "solID")