Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eikonal solver for MFEM #4248

Merged
merged 35 commits into from
Jun 1, 2024
Merged

Eikonal solver for MFEM #4248

merged 35 commits into from
Jun 1, 2024

Conversation

brendankeith
Copy link
Member

@brendankeith brendankeith commented Apr 15, 2024

This PR presents a new high-order solver for the eikonal equation,
$$|\nabla u | = 1 ~\text{ in } \Omega, \quad u = 0 ~\text{ on }\partial \Omega.$$

The proximal Galerkin method used to solve this problem is based on ongoing research with Surowiec, Farrell, and Dokken.

main

PR Author Editor Reviewers Assignment Approval Merge
#4248 @brendankeith @tzanio @bslazarov + @psocratis + @vladotomov 4/17/24 5/29/24 6/1/24
PR Checklist
  • Code builds.
  • Code passes make style.
  • Update CHANGELOG:
    • Is this a new feature users need to be aware of? New or updated example or miniapp?
    • Does it make sense to create a new section in the CHANGELOG to group with other related features?
  • Update INSTALL:
    • Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
    • Have the version ranges for any required or optional libraries changed?
    • Does make or cmake have a new target?
    • Did the requirements or the installation process change? (rare)
  • Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)
    • .github
    • .appveyor.yml
  • Update .gitignore:
    • Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
    • Add new patterns (just for the new files above) and re-run the above test.
  • New examples:
    • All sample runs at the top of the example source file work.
    • Update examples/makefile:
      • Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
      • Add any files generated by it to the clean target.
      • Add the example binary and any files generated by it to the top-level .gitignore file.
    • Update examples/CMakeLists.txt:
      • Add the example code to the ALL_EXE_SRCS variable.
      • Make sure THIS_TEST_OPTIONS is set correctly for the new example.
    • List the new example in doc/CodeDocumentation.dox.
    • If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
    • Companion pull request for documentation in mfem/web repo:
      • Update or add example-specific documentation, see e.g. the src/examples.md.
      • Add the description, labels and screenshots in src/examples.md and src/img.
      • In examples.md, list the example under the appropriate categories, add new categories if necessary.
      • Add a short description of the example in the "Extensive Examples" section of features.md.
  • New miniapps:
    • All sample runs at the top of the miniapp source file work.
    • Update top-level makefile and makefile in corresponding miniapp directory.
    • Add the miniapp binary and any files generated by it to the top-level .gitignore file.
    • Update CMake build system:
      • Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
      • Add/update the CMakeLists.txt file in the new miniapp directory.
      • Consider adding a new test for the new miniapp.
    • List the new miniapp in doc/CodeDocumentation.dox
    • If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
    • If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
    • Companion pull request for documentation in mfem/web repo:
      • Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
      • Add the description, labels and screenshots in src/examples.md and src/img.
      • The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
      • Add a short description of the miniapp in the "Extensive Examples" section of features.md.
  • New capability:
    • All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
    • Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
    • Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
    • Consider adding new sample runs in existing examples to highlight the new capability.
    • Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
    • If this is a major new feature, consider mentioning it in the short summary inside README (rare).
    • List major new classes in doc/CodeDocumentation.dox (rare).
  • Update this checklist, if the new pull request affects it.
  • Run make unittest to make sure all unit tests pass.
  • Run the tests in tests/scripts.
  • (LLNL only) After merging:
    • Update internal tests to include the new features.

@brendankeith brendankeith added ready-for-review and removed WIP Work in Progress labels Apr 15, 2024
@brendankeith
Copy link
Member Author

This is now ready for review

examples/ex40.cpp Outdated Show resolved Hide resolved
examples/ex40.cpp Show resolved Hide resolved
examples/ex40.cpp Outdated Show resolved Hide resolved
examples/ex40.cpp Outdated Show resolved Hide resolved
examples/ex40.cpp Outdated Show resolved Hide resolved
examples/ex40.cpp Outdated Show resolved Hide resolved
examples/ex40.cpp Outdated Show resolved Hide resolved
examples/ex40p.cpp Outdated Show resolved Hide resolved
@brendankeith
Copy link
Member Author

brendankeith commented Apr 17, 2024

Thank you for the comments, @dohyun-cse! With help from @psocratis, I think I could implement all of them.

Please take a look to see if I missed anything

@tzanio
Copy link
Member

tzanio commented May 11, 2024

@bslazarov and @psocratis, can you please review?

CHANGELOG Outdated Show resolved Hide resolved
@tzanio
Copy link
Member

tzanio commented May 22, 2024

This is a really cool example, thanks @brendankeith!

Can you also

  • List it in doc/CodeDocumentation.dox
  • Prepare the corresponding description in mfem/web

examples/ex40.cpp Outdated Show resolved Hide resolved
examples/ex40p.cpp Outdated Show resolved Hide resolved
brendankeith and others added 3 commits May 22, 2024 20:21
Co-authored-by: Socratis Petrides <petrides1@llnl.gov>
Co-authored-by: Socratis Petrides <petrides1@llnl.gov>
@brendankeith
Copy link
Member Author

brendankeith commented May 23, 2024

This is a really cool example, thanks @brendankeith!

Can you also

  • List it in doc/CodeDocumentation.dox
  • Prepare the corresponding description in mfem/web

Thanks! I will prioritize the web PR once this PR gets two approvals

CHANGELOG Outdated Show resolved Hide resolved
examples/ex40.cpp Outdated Show resolved Hide resolved
examples/ex40p.cpp Outdated Show resolved Hide resolved
Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great example, thanks @brendankeith !

@tzanio
Copy link
Member

tzanio commented May 29, 2024

Merged in next for testing...

@tzanio tzanio added the in-next label May 29, 2024
tzanio added a commit that referenced this pull request May 29, 2024
@brendankeith
Copy link
Member Author

Thanks for reviewing my PR, @vladotomov, @dohyun-cse, @psocratis, and @tzanio !!

@tzanio tzanio merged commit 7e8fc14 into master Jun 1, 2024
28 checks passed
Pull Requests automation moved this from Review Now to Merged Jun 1, 2024
@tzanio tzanio deleted the ex40 branch June 1, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pull Requests
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants