.Net: Fix CI pipeline for Windows runner #6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrostruk
changed the title
|
What is the problem this is fixing? Thanks. |
@stephentoub Sorry I didn't put PR description yet since I'm still working on it, and I need CI pipeline to run for testing. Problem: Even though we have I want to enable running it on Windows as well. |
|
Oh, wow, have we never been running on Windows, or is this a recent regression? |
Not sure, but I'm just trying to fix it :) Should be ready soon. |
Ready, it should work as expected now. I left screenshots in PR description. |
westey-m
approved these changes
May 17, 2024
markwallace-microsoft
approved these changes
May 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 17, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> We have `windows` as OS in our CI matrix, but it is not used, and we build and run solution on Ubuntu only. This PR enables Windows in pipeline. Note: removal of `<returns></returns>` in changes was required to trigger .NET pipeline for testing. Before:  After:  ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 馃槃
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
markwallace-microsoft
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We have
windowsas OS in our CI matrix, but it is not used, and we build and run solution on Ubuntu only.This PR enables Windows in pipeline.
Note: removal of
<returns></returns>in changes was required to trigger .NET pipeline for testing.Before:
After:
Contribution Checklist