-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Fix CI pipeline for Windows runner #6304
Conversation
What is the problem this is fixing? Thanks. |
@stephentoub Sorry I didn't put PR description yet since I'm still working on it, and I need CI pipeline to run for testing. Problem: Even though we have I want to enable running it on Windows as well. |
Oh, wow, have we never been running on Windows, or is this a recent regression? |
Not sure, but I'm just trying to fix it :) Should be ready soon. |
Ready, it should work as expected now. I left screenshots in PR description. |
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> We have `windows` as OS in our CI matrix, but it is not used, and we build and run solution on Ubuntu only. This PR enables Windows in pipeline. Note: removal of `<returns></returns>` in changes was required to trigger .NET pipeline for testing. Before: ![image](https://github.com/microsoft/semantic-kernel/assets/13853051/7954d3b6-fc88-4dc6-8464-8b5690d48947) After: ![image](https://github.com/microsoft/semantic-kernel/assets/13853051/02f10392-2931-4103-b875-07dd529f7590) ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> We have `windows` as OS in our CI matrix, but it is not used, and we build and run solution on Ubuntu only. This PR enables Windows in pipeline. Note: removal of `<returns></returns>` in changes was required to trigger .NET pipeline for testing. Before: ![image](https://github.com/microsoft/semantic-kernel/assets/13853051/7954d3b6-fc88-4dc6-8464-8b5690d48947) After: ![image](https://github.com/microsoft/semantic-kernel/assets/13853051/02f10392-2931-4103-b875-07dd529f7590) ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Motivation and Context
We have
windows
as OS in our CI matrix, but it is not used, and we build and run solution on Ubuntu only.This PR enables Windows in pipeline.
Note: removal of
<returns></returns>
in changes was required to trigger .NET pipeline for testing.Before:
After:
Contribution Checklist