fix(db): Prevent data loss by temporarily disabling db:convert-type
#45400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed until #45257 is addressed to prevent data loss Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
nickvergessen,
ChristophWurst,
juliushaertl and
kesselb
|
/backport to stable29 |
Signed-off-by: Josh <josh.t.richards@gmail.com>
come-nc
approved these changes
May 21, 2024
Altahrim
approved these changes
May 21, 2024
ChristophWurst
approved these changes
May 22, 2024
|
Hi, can this be reverted now that #45013 is merged? |
This comment was marked as outdated.
This comment was marked as outdated.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: Needed until #45257 is addressed to prevent data loss
Summary
Currently the bug described in #45257 (and related #45097) has a serious side effect/interaction with the
occ db:convert-typecommand which results in dropping the source database.Based on preliminary analysis, this is likely a bug arising from changes made in #41998 that were released as part of 29.0.0.
If we're unable to address #45257 prior to the release of 29.0.1 in a few days, then I propose we disable
occ db:convert-typetemporarily (hopefully just until the next maintenance release) rather than risk people wiping out their database. That is the purpose of this PR.This is a backup PR which I propose merging in
masterand backporting to 29.0.1 prior to it being published if necessary.If it turns out to be unnecessary, all the better.
TODO
Checklist