Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to APIs deprecated in V8 12.6 #52991

Closed
ajklein opened this issue May 14, 2024 · 1 comment
Closed

Remove calls to APIs deprecated in V8 12.6 #52991

ajklein opened this issue May 14, 2024 · 1 comment
Labels
deprecations Issues and PRs related to deprecations. v8 engine Issues and PRs related to the V8 dependency.

Comments

@ajklein
Copy link
Contributor

ajklein commented May 14, 2024 •
edited

Both updates are trivial:

  • v8::ScriptOrigin's constructor no longer takes an Isolate (it was already unused)
  • v8::SafeForTerminationScope and the Isolate creation param only_terminate_in_safe_scope are gone (they were already no-ops)

See v8#185 for the fixes I made to keep V8's CI happy.

cc @joyeecheung
@marco-ippolito marco-ippolito added v8 engine Issues and PRs related to the V8 dependency. deprecations Issues and PRs related to deprecations. labels May 15, 2024
targos pushed a commit to targos/node that referenced this issue May 15, 2024
@ajklein @targos
src: remove calls to recently deprecated V8 APIs
b584849 
Closes: nodejs#52991
@targos targos mentioned this issue May 15, 2024
Closed
@targos
Copy link
Member

targos commented May 15, 2024

Thanks for the heads up! I opened #52996 with your changes.

targos pushed a commit that referenced this issue May 21, 2024
@ajklein @targos
src: remove calls to recently deprecated V8 APIs
d750a3c 
Closes: #52991
PR-URL: #52996
Fixes: #52991
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: remove calls to recently deprecated V8 APIs targos/node
3 participants
@ajklein @targos @marco-ippolito