src: remove calls to recently deprecated V8 APIs #52996
Closed
+14
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
added
dont-land-on-v18.x
nodejs-github-bot
added
c++
targos
added
the
commit-queue-rebase
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
approved these changes
May 17, 2024
legendecas
added
author ready
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/52996 ✔ Done loading data for nodejs/node/pull/52996 ----------------------------------- PR info ------------------------------------ Title src: remove calls to recently deprecated V8 APIs (#52996) Author Michaël Zasso (@targos) Branch targos:v8-deprecated-script-origin -> nodejs:main Labels c++, vm, author ready, needs-ci, commit-queue-rebase, dont-land-on-v18.x, dont-land-on-v20.x Commits 1 - src: remove calls to recently deprecated V8 APIs Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/52996 Fixes: https://github.com/nodejs/node/issues/52991 Reviewed-By: Chengzhong Wu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52996 Fixes: https://github.com/nodejs/node/issues/52991 Reviewed-By: Chengzhong Wu -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 15 May 2024 07:17:06 GMT ✔ Approvals: 1 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/52996#pullrequestreview-2062902091 ✘ This PR needs to wait 115 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-16T00:22:45Z: https://ci.nodejs.org/job/node-test-pull-request/59234/ - Querying data for job/node-test-pull-request/59234/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9127373069 |
nodejs-github-bot
added
the
commit-queue-failed
legendecas
removed
the
commit-queue-failed
|
@nodejs/cpp-reviewers |
anonrig
approved these changes
May 18, 2024
juanarbol
approved these changes
May 19, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a619789...a6d54f1 |
clavin
added a commit
to electron/electron
that referenced
this pull request
May 23, 2024
Node.js PR: nodejs/node#52996 V8 API Removal CL: https://chromium-review.googlesource.com/c/v8/v8/+/5539888 See the patch description for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #52991