Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ibc hooks to not throw error on every ack. #388

Merged
merged 2 commits into from
Mar 17, 2023
Merged

fix ibc hooks to not throw error on every ack. #388

merged 2 commits into from
Mar 17, 2023

Conversation

puneet2019
Copy link
Member

1. Overview

Fixes logging on ibc hooks..

@puneet2019 puneet2019 requested review from ajeet97 and xlab March 16, 2023 18:33
@github-actions
Copy link

Coverage after merging puneet/ibchook-fixlogs into master

21.94%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   test_suite.go100%100%0%..., 52, 53, 54, 56
   state.go100%100%0%..., 96, 97, 98, 99
   config.go100%100%56.10%..., 72, 73, 74, 75
   genesis.go100%100%100%
   utils.go100%100%20.25%..., 96, 97, 98, 99
   genesis_account.go100%100%100%
   test_helpers.go100%100%0.93%..., 96, 97, 98, 99
   app.go100%100%77.41%..., 649, 650, 651, 652
   encoding.go100%100%100%
   export.go100%100%15.27%..., 93, 97, 98, 99
simapp/simd/cmd
   root.go100%100%72.69%..., 66, 67, 70, 71
   testnet.go100%100%79.44%..., 408, 409, 62, 63
   genaccounts.go100%100%72.44%..., 95, 97, 98, 99
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
   tx.go100%100%0%..., 22, 23, 24, 25
x/epochs/keeper
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
   genesis.go100%100%90.91%14
   hooks.go100%100%100%
   keeper.go100%100%92.86%30
   epoch.go100%100%85.71%..., 26, 62, 88, 93
   abci.go100%100%100%
x/epochs/types
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   keys.go100%100%0%20, 21, 22
   genesis.go100%100%59.18%..., 57, 58, 61, 62
   identifier.go100%100%0%..., 25, 7, 8, 9
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
   hooks.go100%100%100%
   genesis.pb.go100%100%27.83%..., 96, 97, 98, 99
x/halving/simulation
   genesis.go100%100%100%
   params.go100%100%100%
x/halving/types
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   params.go100%100%85.29%23, 24, 25, 43, 44
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
   genesis.go100%100%86.67%25, 26
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
x/interchainquery
   module.go100%100%62.50%..., 87, 90, 91, 92
   genesis.go100%100%54.55%21, 22, 23, 24, 25
   handler.go100%100%40%16, 17, 18
x/interchainquery/keeper
   queries.go100%100%98%66
   keeper.go100%100%67.59%..., 64, 65, 87, 99
   abci.go100%100%92.68%58, 59, 60
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
   msg_server.go100%100%65.08%..., 71, 74, 82, 83
x/interchainquery/types
   keys.go100%100%0%28, 29, 30
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
   codec.go100%100%100%
   genesis.go100%100%63.64%15, 16, 17, 18
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999
   msgs.go100%100%56%..., 42, 48, 49, 50
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99

@github-actions
Copy link

Coverage after merging puneet/ibchook-fixlogs into master

21.94%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   test_suite.go100%100%0%..., 52, 53, 54, 56
   config.go100%100%56.10%..., 72, 73, 74, 75
   encoding.go100%100%100%
   test_helpers.go100%100%0.93%..., 96, 97, 98, 99
   app.go100%100%77.41%..., 649, 650, 651, 652
   genesis.go100%100%100%
   export.go100%100%15.27%..., 93, 97, 98, 99
   genesis_account.go100%100%100%
   state.go100%100%0%..., 96, 97, 98, 99
   utils.go100%100%20.25%..., 96, 97, 98, 99
simapp/simd/cmd
   testnet.go100%100%79.44%..., 408, 409, 62, 63
   genaccounts.go100%100%72.44%..., 95, 97, 98, 99
   root.go100%100%72.69%..., 66, 67, 70, 71
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
   tx.go100%100%0%..., 22, 23, 24, 25
x/epochs/keeper
   epoch.go100%100%85.71%..., 26, 62, 88, 93
   keeper.go100%100%92.86%30
   hooks.go100%100%100%
   abci.go100%100%100%
   genesis.go100%100%90.91%14
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
x/epochs/types
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
   genesis.pb.go100%100%27.83%..., 96, 97, 98, 99
   identifier.go100%100%0%..., 25, 7, 8, 9
   keys.go100%100%0%20, 21, 22
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   hooks.go100%100%100%
   genesis.go100%100%59.18%..., 57, 58, 61, 62
x/halving/simulation
   genesis.go100%100%100%
   params.go100%100%100%
x/halving/types
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
   genesis.go100%100%86.67%25, 26
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   params.go100%100%85.29%23, 24, 25, 43, 44
x/interchainquery
   handler.go100%100%40%16, 17, 18
   module.go100%100%62.50%..., 87, 90, 91, 92
   genesis.go100%100%54.55%21, 22, 23, 24, 25
x/interchainquery/keeper
   queries.go100%100%98%66
   keeper.go100%100%67.59%..., 64, 65, 87, 99
   msg_server.go100%100%65.08%..., 71, 74, 82, 83
   abci.go100%100%92.68%58, 59, 60
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
x/interchainquery/types
   msgs.go100%100%56%..., 42, 48, 49, 50
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
   codec.go100%100%100%
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
   keys.go100%100%0%28, 29, 30
   genesis.go100%100%63.64%15, 16, 17, 18
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999

@puneet2019 puneet2019 requested a review from kruspy March 17, 2023 10:14
@puneet2019 puneet2019 merged commit 7678b4f into master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruspy kruspy kruspy approved these changes

@ajeet97 ajeet97 Awaiting requested review from ajeet97

@xlab xlab Awaiting requested review from xlab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@puneet2019 @kruspy