Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC use pydata-sphinx-theme for the website #29038

Merged
merged 43 commits into from
May 20, 2024
Merged

DOC use pydata-sphinx-theme for the website #29038

merged 43 commits into from
May 20, 2024

Conversation

adrinjalali
Copy link
Member

This work is done mostly by @Charlie-XIAO , this is a PR to merge the work into the main branch.

Charlie-XIAO and others added 28 commits January 31, 2024 18:50
@Charlie-XIAO
DOC switch to pydata-sphinx-theme [1] conf, setup, general styling (#…
7bcadac 
…28132)
@adrinjalali
Merge branch 'new_web_theme' of github.com:scikit-learn/scikit-learn …
5f311fe 
…into new_web_theme
@Charlie-XIAO
MAINT [PST] set up live preview (#28353)
f635307
@Charlie-XIAO
DOC [PST] fix lock files and add sphinx-design (#28379)
e8025fa
@Charlie-XIAO
DOC [PST] install page (#28336)
d53cfbc
@Charlie-XIAO
DOC [PST] tune toctree-related styles (#28408)
1dceba9
@Charlie-XIAO
DOC [PST] fix changelog badges (#28409)
ed0e150
@adrinjalali
Merge remote-tracking branch 'origin/main' into new_web_theme
b1b3d0f
@Charlie-XIAO
DOC [PST] better integrate gallery with pydata-sphinx-theme (#28415)
dbeb1b3
@Charlie-XIAO
Merge remote-tracking branch 'origin/main' into new_web_theme
19196ca
@Charlie-XIAO
Merge remote-tracking branch 'origin/main' into new_web_theme
f568cbe
@Charlie-XIAO
Merge remote-tracking branch 'origin/main' into new_web_theme
3c7f448
@Charlie-XIAO
DOC [PST] landing page (#28331)
2520ff4
@Charlie-XIAO
Merge remote-tracking branch 'origin/main' into new_web_theme
6c97e77
@Charlie-XIAO @thomasjpfan
DOC [PST] use jinja2 template for rst generation (#28511)
51a36eb 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@Charlie-XIAO
Merge remote-tracking branch 'origin/main' into new_web_theme
738c089
@Charlie-XIAO
DOC [PST] version switcher and warning banner (#28347)
05eb574
@Charlie-XIAO
try fixing version warning banner
4e874ff
@Charlie-XIAO
fix typo in version switcher generator
30a21d6
@Charlie-XIAO
DOC [PST] disable gallery link tweaks when html-noplot to avoid war…
3400749 
…nings (#28512)
@Charlie-XIAO
fix wrong path in version switcher
7bda6d4
@Charlie-XIAO
DOC [PST] tune FAQ page styling (#28448)
3852926
@Charlie-XIAO
DOC [PST] refactor API structure and improve display (#28428)
b9f8f27
@Charlie-XIAO
DOC [PST] fix dropdowns (#28401)
c1adbac
@Charlie-XIAO @adrinjalali
DOC [PST] FIX/RFC machine learning map (#28630)
321d683 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@Charlie-XIAO @glemaitre
DOC [PST] fix styling/simplify structure of testimonial and about pag…
b548b7c 
…es (#28623)

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
@Charlie-XIAO
Merge remote-tracking branch 'origin/main' into new_web_theme
a1ed6ef
@Charlie-XIAO
Merge remote-tracking branch 'origin/main' into new_web_theme
4864b3d
@adrinjalali adrinjalali mentioned this pull request May 17, 2024
Closed
@glemaitre
Copy link
Member

Did we remove the doc-min-dependencies build? Since this is a required build, we are in a weird state right now I think.

@Charlie-XIAO
Copy link
Contributor

Charlie-XIAO commented May 19, 2024 •
edited

Yes, as suggested in #28379 (comment). I'm adding it back in #29037, which should be merged into new_web_theme before we merge this one.

@Charlie-XIAO Charlie-XIAO mentioned this pull request May 20, 2024
Merged
8 tasks
@glemaitre glemaitre changed the title DOC New web theme for the website DOC use pydata-sphinx-theme for the website May 20, 2024
@glemaitre
Copy link
Member

I made the last changes and pushed a full rebuild.

jeremiedbb
jeremiedbb approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green. I quickly skimmed trough the generated web site and everything looks good. Thanks @Charlie-XIAO !

glemaitre
glemaitre approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the work @Charlie-XIAO

@glemaitre glemaitre merged commit 34db65a into main May 20, 2024
32 checks passed
@glemaitre glemaitre deleted the new_web_theme branch May 20, 2024 17:37
@betatim
Copy link
Member

betatim commented May 21, 2024

Will we get this theme for the 1.5 website (aka the one people will see under /stable/ after 1.5 has been released)?

It would be nice to get it out, but given how little time there is between now and the release of 1.5 it might be smart to use the old theme for 1.5 and have this on the /dev/ until 1.6? What do people think? (and is there a different issue to use for discussing this?)

@betatim betatim mentioned this pull request May 21, 2024
Merged
14 tasks
@glemaitre
Copy link
Member

Basically, I would not delay and have the theme for 1.5. We had iteration in the branch new_theme_web for some time and even though we will have a couple of hidden glitches, the benefit is higher than the risk here.

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request May 21, 2024
@adrinjalali @Charlie-XIAO
@thomasjpfan @glemaitre @jeremiedbb
DOC use pydata-sphinx-theme for the website (scikit-learn#29038)
591c01d 
Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
jeremiedbb pushed a commit that referenced this pull request May 21, 2024
@adrinjalali @Charlie-XIAO
@thomasjpfan @glemaitre @jeremiedbb
DOC use pydata-sphinx-theme for the website (#29038)
f83f9bf 
Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
@jjerphan
Copy link
Member

Thank you for this work, @Charlie-XIAO! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
Documentation No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adrinjalali @glemaitre @Charlie-XIAO @betatim @jjerphan @jeremiedbb