New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta-issue] Notebooks are outdated / non-runnable #3036
Comments
This is a great endeavour! It might be helpful to add the guidelines for notebooks (e.g. linters, style etc) in the contributing guide, perhaps under a general section about "things in need of attention" |
Another idea which could support this endeavour could be to make use of some more Sphinx features to make the notebooks a bit more navigable, for example the Gallery view. There's a guide here: |
+1 as I was trying to read the docs and many images were missing |
@thatlittleboy I noticed that we seem to have two separate sets of notebooks used for documentation:
Shall we aim to remove this duplication, putting everything in one place in one format? |
Hi, |
Have you installed pre-commit in your working environment? Have a look in the contributing guide for more detailed steps, and let us know if anything isn't clear. Your specific issue seems to be because some files have not been auto-formatted correctly. You should be able to fix your issue by running:
Then, commit and push your changes as usual. Nb. alternatively, you can run the ruff linter directly on a notebook with:
Note that you need the latest ruff version installed to lint |
Thanks ! Managed to use |
@connortann Sorry I missed this, yea seems like a good idea. Let's leave it as a to-do. |
Hope that Image Multiclass Classification Benchmark Demo.ipynb can be fixed soon. OVO |
Background
We should also make sure that our documentation is kept up to date.
A scour through the open issues in this repo and also on StackOverflow shows that the outdated documentation (or lackthereof) is causing confusion among our users.
Just some examples:
Plan
The plan here is to thoroughly go through each and every notebook example that we have, to:
Explanation
API for plottingWhile we're at it, I also propose to clean up the notebook metadata (remove kernel information, etc.) to minimize git conflicts, and also to run linters (ruff) / formatters (black) to keep the notebook code tidy.
I might formalize this in a separate issue later (outside the scope of this meta-issue).
An example of such a PR: #3037
To potential contributors (thank you in advance!), please stick to one notebook per PR when contributing.
Also, any help in updating the GPU-related notebooks would be very much appreciated.
TODO
BostonCalifornia Demo.ipynb (Notebook simple boston demo #3332)The text was updated successfully, but these errors were encountered: