-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced Boston dataset with California in Catboost tutorial #3214
Replaced Boston dataset with California in Catboost tutorial #3214
Conversation
Thanks @owenlamont for the contribution. It's a little hard to review notebooks on GH, I'll use images to get my point across:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above.
Cheers, yeah I should've been aware the features would be different, I'll get onto those updates. |
…e California dataset.
@owenlamont I went round all the variables and didn't really find any variables' dependence plot to be particularly illustrative / easy to interpret. What do you think about this instead? It's the best I could come up with. I'm seeing that:
|
… Age and updated description
Thanks for the feedback @thatlittleboy - I've used your example and tweaked your phrasing a little for the description. I hope that looks okay: I also noticed the old Boston House Price example is used on the main README too... guess at some point that should be changed. I think we might want an entirely different dataset we can tell a nice story with using SHAP for that though. |
@owenlamont this has been fixed by #3200. Happy for another dataset to be used if it tells a more compelling story. |
Yeah... I'm sure there must be a better dataset for this example. I'm afraid I'm a bit time poor and have some other priorities so I don't think I'll go looking for it myself but happy to try and keep contributing in small ways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @owenlamont for the contribution, Sorry it took so long to get back to you. I took the liberty to clean up a couple more things, like using the new plots
api (e.g. shap.plots.force
instead of shap.force_plot
) where possible.
Thanks for finishing it off @thatlittleboy ! |
Overview
Description of the changes proposed in this pull request:
This is another step towards completing issue 2322.
Checklist